[jira] Commented: (LOG4PHP-30) Implement LoggerAppenderPDO

["Knut Urdalen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4PHP-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706743#action_12706743 ] 

Knut Urdalen commented on LOG4PHP-30:
-------------------------------------

The PDO ctor throws a PDOException if connection to database fails, I see you currently check if($this->db === null) to check if connection went ok.

See: http://php.net/manual/en/pdo.construct.php


> Implement LoggerAppenderPDO
> ---------------------------
>
>                 Key: LOG4PHP-30
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-30
>             Project: Log4php
>          Issue Type: New Feature
>          Components: Code
>            Reporter: Knut Urdalen
>            Assignee: Christian Grobmeier
>             Fix For: 2.0
>
>
> We should provide a LoggerAppenderPDO which utilize the PDO extension and available PDO-drivers. This would be preferred over LoggerAppenderDb (which used the outdated PEAR::DB library).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Commented: (LOG4PHP-30) Implement LoggerAppenderPDO

[Christian Grobmeier <gr...@gmail.com>]

> The PDO ctor throws a PDOException if connection to database fails, I see you currently check if($this->db === null) to check if connection went ok.
>
> See: http://php.net/manual/en/pdo.construct.php

true, I used the AdoDB class as template. Thanks.

However - we have to decide how to deal with such kinds of exception.
Should we catch them and throw LoggerException instead, supress them
or simply let it flow?

I think option 1 and 3 are legal, I currently tend to option 3.

Cheers