[GitHub] [superset] prosdev0107 commented on a diff in pull request #19291: fix: Saved query without description issue, None showing (Preset-Patch)

[GitBox <gi...@apache.org>]

prosdev0107 commented on code in PR #19291:
URL: https://github.com/apache/superset/pull/19291#discussion_r855394857


##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1273,6 +1273,11 @@ export function popSavedQuery(saveQueryId) {
       endpoint: `/savedqueryviewapi/api/get/${saveQueryId}`,
     })
       .then(({ json }) => {
+        // if description from result is 'None', need to omit this property.
+        if(json.result.description === 'None') {

Review Comment:
   I also think that it would be better if this issue can be fixed on backend side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org