You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "harikrishna-patnala (via GitHub)" <gi...@apache.org> on 2023/09/05 03:18:55 UTC
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #7939: UI: Fix user role login due to missing API access on custom hypervisor name
harikrishna-patnala commented on code in PR #7939:
URL: https://github.com/apache/cloudstack/pull/7939#discussion_r1315321490
##########
api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java:
##########
@@ -100,6 +100,10 @@ public class CapabilitiesResponse extends BaseResponse {
@Param(description = "true if experimental features for Kubernetes cluster such as Docker private registry are enabled, false otherwise")
private boolean kubernetesClusterExperimentalFeaturesEnabled;
+ @SerializedName("customhypervisordisplayname")
+ @Param(description = "Display name for custom hypervisor")
Review Comment:
do we have the tradition of adding since parameter in response ? If yes, can you please add that. Remaining code LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org