You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/01 01:38:52 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request, #4456: Treat Gradle disk cache at least as evaluated.
lkishalmi opened a new pull request, #4456:
URL: https://github.com/apache/netbeans/pull/4456
This patch treats the on-dosk Gradle cache data as EVALUATED even if invalid. Usually there is a good chance that the information there is still better, than we can get from the heuristics.
This one would make ```ClassPathProviderImplTest.testCompilePreTrusted``` happy.
I hope this is not too late for NB15. Please review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4456: Treat Gradle disk cache at least as evaluated.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4456:
URL: https://github.com/apache/netbeans/pull/4456#issuecomment-1201522011
IMHO if the user uses goto type to open a source from such 'degraded' project, library dependencies could be loaded from the cache and symbols in the source could resolve much better. The same for any other navigation that targets souces from such project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4456: Treat Gradle disk cache at least as evaluated.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4456:
URL: https://github.com/apache/netbeans/pull/4456#issuecomment-1200946257
Not too late for rc3 if we can merge tomorrow. cc @sdedic !
Aside from `ClassPathProviderImplTest.testCompilePreTrusted`, when is this problem likely to hit an end user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4456: Treat Gradle disk cache at least as evaluated.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4456:
URL: https://github.com/apache/netbeans/pull/4456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4456: Treat Gradle disk cache at least as evaluated.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4456:
URL: https://github.com/apache/netbeans/pull/4456#issuecomment-1201514445
Well, the end user may not even notice the difference that this fix provides. I'd say some refactoring things in a partially opened Gradle multi-project tree would be more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists