You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/04/12 07:45:08 UTC

[GitHub] [celix] PengZheng commented on a diff in pull request #413: Fix rsa use after free

PengZheng commented on code in PR #413:
URL: https://github.com/apache/celix/pull/413#discussion_r848091707


##########
bundles/remote_services/topology_manager/src/topology_manager.c:
##########
@@ -62,6 +62,7 @@ struct topology_manager {
 	celix_thread_mutex_t importedServicesLock;
 	celix_thread_mutexattr_t importedServicesLockAttr;
 	hash_map_pt importedServices;
+	bool stopAddImportedService;

Review Comment:
   I suggest renaming it to `closed`. We should not try to add imported services to a closed listener.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org