You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vicennial (via GitHub)" <gi...@apache.org> on 2023/04/21 05:37:43 UTC
[GitHub] [spark] vicennial opened a new pull request, #40894: [SPARK-43198][CONNECT] Fix "Could not initialise class ammonite..." error when using filter
vicennial opened a new pull request, #40894:
URL: https://github.com/apache/spark/pull/40894
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR makes the ammonite REPL use the `CodeClassWrapper` mode for classfile generation (make ammonite generate classes instead of objects) and changes the UDF serialization from lazy to eager.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The changes have the following impact:
- `CodeClassWrapper` change
- Fixes the `io.grpc.StatusRuntimeException: UNKNOWN: ammonite/repl/ReplBridge$` error when trying to use the `filter` method (see [jira](https://issues.apache.org/jira/browse/SPARK-43198) for reproduction)
- Lazy to eager UDF serialization
- With class-based generation, UDFs defined using `def` would hit CNFE because the `ScalarUserDefinedFuntion` class gets captured during serialisation and sent over to the server (the class is a client-only class).
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behaviour and the change this PR proposes - provide the console output, description and/or an example to show the behaviour difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. There are two significant changes:
- Filter works as expected when using "in-place" lambda expressions such as in `spark.range(10).filter(n => n % 2 == 0).collectAsList()`
- UDFs defined using a lambda expression which is stored in a `val` fail due to deserialisation issues on the server.
- Root cause is currently unknown but a ticket has been [filed](https://issues.apache.org/jira/browse/SPARK-43227) to address the issue.
- Example: see [this](https://github.com/apache/spark/compare/master...vicennial:spark:SPARK-43198?expand=1#diff-8d8a214eff5d2c8d523b59f2a39758ddfa84912ef7d4e0276f54e979a58f88e0R120-R129) test.
- Currently, it is a compromise to get `filter` working as expected since that bug is a higher-impact due to it impacting the "general" way of using the method.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #40894: [SPARK-43198][CONNECT] Fix "Could not initialise class ammonite..." error when using filter
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #40894: [SPARK-43198][CONNECT] Fix "Could not initialise class ammonite..." error when using filter
URL: https://github.com/apache/spark/pull/40894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #40894: [SPARK-43198][CONNECT] Fix "Could not initialise class ammonite..." error when using filter
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #40894:
URL: https://github.com/apache/spark/pull/40894#issuecomment-1523687453
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org