[jira] Updated: (QPID-11) Move protocol literals from code to AMQConstant

["Marnie McCormack (JIRA)" <qp...@incubator.apache.org>]

     [ https://issues.apache.org/jira/browse/QPID-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-11:
---------------------------------

        Fix Version/s:     (was: M2)
                       M3
    Affects Version/s: M2
                       M1

Moving unresolved JIRAs from M2 to M3, in preparation for M2 release

> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
>                 Key: QPID-11
>                 URL: https://issues.apache.org/jira/browse/QPID-11
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: M1, M2
>            Reporter: Martin Ritchie
>            Priority: Trivial
>             Fix For: M3
>
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
>         return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
>                 &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand.  Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.