[jira] [Updated] (PHOENIX-5023) [UMBRELLA] Clean up giant anonymous inner classes

["Chinmay Kulkarni (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chinmay Kulkarni updated PHOENIX-5023:
--------------------------------------
    Labels: phoenix-hardening  (was: )

> [UMBRELLA] Clean up giant anonymous inner classes
> -------------------------------------------------
>
>                 Key: PHOENIX-5023
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5023
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Priority: Minor
>              Labels: phoenix-hardening
>
> A frequent anti-pattern in the Phoenix code base is the use of huge anonymous inner classes, often in the midst of functions that are already very large, or even the parameter list of constructor calls. (The latter means that we have single statements that are technically hundreds of lines long!)  
> This makes the logic difficult to follow and prevents abstraction. Modern IDEs make changing these to named inner classes quite simple. 
> This is intended as an umbrella item with subtasks refactoring particular classes, which can be added to over time. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)