You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/09 00:34:30 UTC
Review Request 21242: Added tooltip to a disabled task sandbox link.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21242/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Bill Farner.
Bugs: AURORA-402
https://issues.apache.org/jira/browse/AURORA-402
Repository: aurora
Description
-------
Added a tooltip to a disabled task sandbox link.
Please see the discussion in the ticket.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html ae10d91359523a7aeff935d93d60f5561ec1290d
Diff: https://reviews.apache.org/r/21242/diff/
Testing
-------
tested on laptop.
File Attachments
----------------
Inactive_sandbox_link_with_tooltip.png
https://reviews.apache.org/media/uploaded/files/2014/05/08/26572a8a-b881-4d2d-9ba1-911a09953b13__Inactive_sandbox_link_with_tooltip.png
Thanks,
Suman Karumuri
Re: Review Request 21242: Added tooltip to a disabled task sandbox link.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21242/#review42596
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 8, 2014, 10:34 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21242/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:34 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-402
> https://issues.apache.org/jira/browse/AURORA-402
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a tooltip to a disabled task sandbox link.
>
> Please see the discussion in the ticket.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html ae10d91359523a7aeff935d93d60f5561ec1290d
>
> Diff: https://reviews.apache.org/r/21242/diff/
>
>
> Testing
> -------
>
> tested on laptop.
>
>
> File Attachments
> ----------------
>
> Inactive_sandbox_link_with_tooltip.png
> https://reviews.apache.org/media/uploaded/files/2014/05/08/26572a8a-b881-4d2d-9ba1-911a09953b13__Inactive_sandbox_link_with_tooltip.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21242: Added tooltip to a disabled task sandbox link.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21242/#review42584
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On May 8, 2014, 10:34 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21242/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:34 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-402
> https://issues.apache.org/jira/browse/AURORA-402
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a tooltip to a disabled task sandbox link.
>
> Please see the discussion in the ticket.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html ae10d91359523a7aeff935d93d60f5561ec1290d
>
> Diff: https://reviews.apache.org/r/21242/diff/
>
>
> Testing
> -------
>
> tested on laptop.
>
>
> File Attachments
> ----------------
>
> Inactive_sandbox_link_with_tooltip.png
> https://reviews.apache.org/media/uploaded/files/2014/05/08/26572a8a-b881-4d2d-9ba1-911a09953b13__Inactive_sandbox_link_with_tooltip.png
>
>
> Thanks,
>
> Suman Karumuri
>
>