You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "shangxinli (via GitHub)" <gi...@apache.org> on 2025/11/02 00:54:14 UTC
[PR] Add validation for AssertCurrentSchemaID [iceberg-cpp]
shangxinli opened a new pull request, #286:
URL: https://github.com/apache/iceberg-cpp/pull/286
Fix table_requirement by implementing AssertCurrentSchemaID::Validate()
This PR implements the missing `AssertCurrentSchemaID::Validate()` method in `table_requirement.cc`, enabling proper validation of schema ID requirements for optimistic concurrency control in table operations.
This is my first contribution to iceberg-cpp. I plan to implement the remaining validation methods in next PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add validation for AssertCurrentSchemaID [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #286:
URL: https://github.com/apache/iceberg-cpp/pull/286#issuecomment-3483417639
Thanks @shangxinli for working on it and @zhjwpku @gty404 for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add validation for AssertCurrentSchemaID [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #286:
URL: https://github.com/apache/iceberg-cpp/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add validation for AssertCurrentSchemaID [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on code in PR #286:
URL: https://github.com/apache/iceberg-cpp/pull/286#discussion_r2484842414
##########
src/iceberg/table_requirement.cc:
##########
@@ -54,7 +54,24 @@ Status AssertLastAssignedFieldId::Validate(const TableMetadata* base) const {
}
Status AssertCurrentSchemaID::Validate(const TableMetadata* base) const {
- return NotImplemented("AssertCurrentTableSchemaID::Validate not implemented");
+ // Validate that the current schema ID matches the expected value
Review Comment:
```suggestion
// Validate that the current schema ID matches the one used when the metadata was read
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org