[GitHub] [trafficserver] ywkaras commented on a change in pull request #7232: Fix lua_states_stats Au test.

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #7232:
URL: https://github.com/apache/trafficserver/pull/7232#discussion_r572393271



##########
File path: tests/gold_tests/pluginTest/lua/lua_states_stats.test.py
##########
@@ -23,16 +23,25 @@
 Test.SkipUnless(
     Condition.PluginExists('tslua.so'),
 )
-Test.SkipIf(Condition.true("Test cannot deterministically wait until the stats appear"))
 
 Test.ContinueOnFail = True
 # Define default ATS
 server = Test.MakeOriginServer("server")
 
-ts = Test.MakeATSProcess("ts", command="traffic_manager", select_ports=True)
+# It is necessary to redirect stderr to a file so it will be available for examination by a test run.
+ts = Test.MakeATSProcess(
+    "ts", command="traffic_manager 2> " + Test.RunDirectory + "/ts.stderr.txt", select_ports=True

Review comment:
       The lifecycle_stats.sh script needs to read the stderr output from traffic_manager.  I tried reading it from the stderr file in _output for the ts process, but the output the script needs gets buffered in memory.  In any case, not good to hardcode the sandbox tree structure into tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org