You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/11 06:22:35 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28186:
[SPARK-31291][SQL][TEST][FOLLOWUP][test-maven] Fix resource loading error
in ThriftServerQueryTestSuite
dongjoon-hyun commented on a change in pull request #28186: [SPARK-31291][SQL][TEST][FOLLOWUP][test-maven] Fix resource loading error in ThriftServerQueryTestSuite
URL: https://github.com/apache/spark/pull/28186#discussion_r407024776
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -53,6 +54,15 @@ import org.apache.spark.sql.types._
*/
class ThriftServerQueryTestSuite extends SQLQueryTestSuite with SharedThriftServer {
+ override protected def testFile(fileName: String): String = {
+ val url = Thread.currentThread().getContextClassLoader.getResource(fileName)
Review comment:
SBT test framework seems to get the correct resource path instead of the embedded resource path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org