You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@kafka.apache.org by "M. Manna" <ma...@gmail.com> on 2019/06/21 01:45:13 UTC

PR review

Hello,

We’ve been waiting for this PR for a while.

https://github.com/apache/kafka/pull/6771

Could this Be reviewed for new release ? This is important for our project.

Thanks,

Re: PR review

Posted by "M. Manna" <ma...@gmail.com>.

I have updated it with my comments - @mjsax could you kindly comment
I stopped watching the issue since it sends all updates to all issues to my
inbox :)

Thanks,

On Sat, 22 Jun 2019 at 10:48, M. Manna <ma...@gmail.com> wrote:

> Thanks Matthias. Moved to dev DL now.
>
> I saw your comment on the PR regarding imports. I’ll fix those and
> resubmit.
>
> Thanks,
>
> On Sat, 22 Jun 2019 at 01:22, Matthias J. Sax <ma...@confluent.io>
> wrote:
>
>> I would recommend to move this discussion to the dev list.
>>
>> -Matthias
>>
>> On 6/20/19 7:42 PM, M. Manna wrote:
>> > It's done. Sorry for the confusion.
>> >
>> > The KIP table however, showed that it's been accepted. But yes it's
>> better
>> > to keep all places consistent.
>> >
>> > Thanks,
>> >
>> > On Fri, 21 Jun 2019 at 03:27, Jeff Widman <je...@jeffwidman.com> wrote:
>> >
>> >> The KIP linked to from the JIRA shows the KIP as still under
>> discussion...
>> >> if it's been voted/approved, then can you please update the wiki page?
>> >>
>> >> On Thu, Jun 20, 2019 at 6:45 PM M. Manna <ma...@gmail.com> wrote:
>> >>
>> >>> Hello,
>> >>>
>> >>> We’ve been waiting for this PR for a while.
>> >>>
>> >>> https://github.com/apache/kafka/pull/6771
>> >>>
>> >>> Could this Be reviewed for new release ? This is important for our
>> >> project.
>> >>>
>> >>> Thanks,
>> >>>
>> >>
>> >>
>> >> --
>> >>
>> >> *Jeff Widman*
>> >> jeffwidman.com <http://www.jeffwidman.com/> | 740-WIDMAN-J (943-6265)
>> >> <><
>> >>
>> >
>>
>>

Re: PR review

Posted by "M. Manna" <ma...@gmail.com>.

Thanks Matthias. Moved to dev DL now.

I saw your comment on the PR regarding imports. I’ll fix those and resubmit.

Thanks,

On Sat, 22 Jun 2019 at 01:22, Matthias J. Sax <ma...@confluent.io> wrote:

> I would recommend to move this discussion to the dev list.
>
> -Matthias
>
> On 6/20/19 7:42 PM, M. Manna wrote:
> > It's done. Sorry for the confusion.
> >
> > The KIP table however, showed that it's been accepted. But yes it's
> better
> > to keep all places consistent.
> >
> > Thanks,
> >
> > On Fri, 21 Jun 2019 at 03:27, Jeff Widman <je...@jeffwidman.com> wrote:
> >
> >> The KIP linked to from the JIRA shows the KIP as still under
> discussion...
> >> if it's been voted/approved, then can you please update the wiki page?
> >>
> >> On Thu, Jun 20, 2019 at 6:45 PM M. Manna <ma...@gmail.com> wrote:
> >>
> >>> Hello,
> >>>
> >>> We’ve been waiting for this PR for a while.
> >>>
> >>> https://github.com/apache/kafka/pull/6771
> >>>
> >>> Could this Be reviewed for new release ? This is important for our
> >> project.
> >>>
> >>> Thanks,
> >>>
> >>
> >>
> >> --
> >>
> >> *Jeff Widman*
> >> jeffwidman.com <http://www.jeffwidman.com/> | 740-WIDMAN-J (943-6265)
> >> <><
> >>
> >
>
>

Re: PR review

Posted by "Matthias J. Sax" <ma...@confluent.io>.

I would recommend to move this discussion to the dev list.

-Matthias

On 6/20/19 7:42 PM, M. Manna wrote:
> It's done. Sorry for the confusion.
> 
> The KIP table however, showed that it's been accepted. But yes it's better
> to keep all places consistent.
> 
> Thanks,
> 
> On Fri, 21 Jun 2019 at 03:27, Jeff Widman <je...@jeffwidman.com> wrote:
> 
>> The KIP linked to from the JIRA shows the KIP as still under discussion...
>> if it's been voted/approved, then can you please update the wiki page?
>>
>> On Thu, Jun 20, 2019 at 6:45 PM M. Manna <ma...@gmail.com> wrote:
>>
>>> Hello,
>>>
>>> We’ve been waiting for this PR for a while.
>>>
>>> https://github.com/apache/kafka/pull/6771
>>>
>>> Could this Be reviewed for new release ? This is important for our
>> project.
>>>
>>> Thanks,
>>>
>>
>>
>> --
>>
>> *Jeff Widman*
>> jeffwidman.com <http://www.jeffwidman.com/> | 740-WIDMAN-J (943-6265)
>> <><
>>
>

Re: PR review

Posted by "M. Manna" <ma...@gmail.com>.

It's done. Sorry for the confusion.

The KIP table however, showed that it's been accepted. But yes it's better
to keep all places consistent.

Thanks,

On Fri, 21 Jun 2019 at 03:27, Jeff Widman <je...@jeffwidman.com> wrote:

> The KIP linked to from the JIRA shows the KIP as still under discussion...
> if it's been voted/approved, then can you please update the wiki page?
>
> On Thu, Jun 20, 2019 at 6:45 PM M. Manna <ma...@gmail.com> wrote:
>
> > Hello,
> >
> > We’ve been waiting for this PR for a while.
> >
> > https://github.com/apache/kafka/pull/6771
> >
> > Could this Be reviewed for new release ? This is important for our
> project.
> >
> > Thanks,
> >
>
>
> --
>
> *Jeff Widman*
> jeffwidman.com <http://www.jeffwidman.com/> | 740-WIDMAN-J (943-6265)
> <><
>

Re: PR review

Posted by Jeff Widman <je...@jeffwidman.com>.

The KIP linked to from the JIRA shows the KIP as still under discussion...
if it's been voted/approved, then can you please update the wiki page?

On Thu, Jun 20, 2019 at 6:45 PM M. Manna <ma...@gmail.com> wrote:

> Hello,
>
> We’ve been waiting for this PR for a while.
>
> https://github.com/apache/kafka/pull/6771
>
> Could this Be reviewed for new release ? This is important for our project.
>
> Thanks,
>


-- 

*Jeff Widman*
jeffwidman.com <http://www.jeffwidman.com/> | 740-WIDMAN-J (943-6265)
<><