You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/05 16:06:43 UTC
[GitHub] [nifi] simonbence opened a new pull request #4314: NIFI-7442 Add CLI commands to the registry in order to support automa…
simonbence opened a new pull request #4314:
URL: https://github.com/apache/nifi/pull/4314
[NIFI-7442](https://issues.apache.org/jira/browse/NIFI-7442)
New commands were added to the CLI to be able to create/update users, user groups and access policies in NiFi Registry. As NiFi depends on released Registry, some code temporarily takes place in NiFi which should be moved to the Registry in the long term. Also, this comes with some code duplication as well (which will be removed in a later point too).
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tpalfy commented on pull request #4314: NIFI-7442 Add CLI commands to the registry in order to support automa…
Posted by GitBox <gi...@apache.org>.
tpalfy commented on pull request #4314:
URL: https://github.com/apache/nifi/pull/4314#issuecomment-642671399
I was reviewing this PR and had some additional updates.
I will submit a new PR with Bence’s work + mine (Bence's commit is preserved in the new PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4314: NIFI-7442 Add CLI commands to the registry in order to support automa…
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4314:
URL: https://github.com/apache/nifi/pull/4314#issuecomment-640599312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tpalfy edited a comment on pull request #4314: NIFI-7442 Add CLI commands to the registry in order to support automa…
Posted by GitBox <gi...@apache.org>.
tpalfy edited a comment on pull request #4314:
URL: https://github.com/apache/nifi/pull/4314#issuecomment-642671399
I was reviewing this PR and had some additional updates.
I will submit a new PR with Bence’s work + mine (Bence's commit is preserved in the new PR).
https://github.com/apache/nifi/pull/4329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence edited a comment on pull request #4314: NIFI-7442 Add CLI commands to the registry in order to support automa…
Posted by GitBox <gi...@apache.org>.
simonbence edited a comment on pull request #4314:
URL: https://github.com/apache/nifi/pull/4314#issuecomment-643939637
@tpalfy Thanks for taking over!
(The idea behind policy management was that creating the policy will return with the ID)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on pull request #4314: NIFI-7442 Add CLI commands to the registry in order to support automa…
Posted by GitBox <gi...@apache.org>.
simonbence commented on pull request #4314:
URL: https://github.com/apache/nifi/pull/4314#issuecomment-643939637
@tpalfy Thanks for taking over!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence closed pull request #4314: NIFI-7442 Add CLI commands to the registry in order to support automa…
Posted by GitBox <gi...@apache.org>.
simonbence closed pull request #4314:
URL: https://github.com/apache/nifi/pull/4314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org