[GitHub] [airflow] josh-fell commented on pull request #25426: Update azure-storage-blob version

[GitBox <gi...@apache.org>]

josh-fell commented on PR #25426:
URL: https://github.com/apache/airflow/pull/25426#issuecomment-1204302313

   > As for the second static failure it's kinda strange. mypy fails with:
   > 
   > ```
   > airflow/providers/microsoft/azure/hooks/wasb.py:232: error: Argument
   > "delimiter" to "walk_blobs" of "ContainerClient" has incompatible type
   > "Optional[str]"; expected "str"  [arg-type]
   >     ...me_starts_with=prefix, include=include, delimiter=delimiter, **kwargs)
   > ```
   > 
   > Code line:
   > 
   > https://github.com/apache/airflow/blob/f18c609d127f54fbbf4dae6b290c6cdcfc7f98d0/airflow/providers/microsoft/azure/hooks/wasb.py#L216
   > 
   > but the types did not change between the versions: https://github.com/Azure/azure-sdk-for-python/blob/azure-storage-blob_12.8.1/sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py#L779
   > 
   > https://github.com/Azure/azure-sdk-for-python/blob/azure-storage-blob_12.13.0/sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py#L780
   > 
   > In 12.8.1 (when mypy pass) it’s the same as in 12.13.0 which mypy fails!
   
   The `delimiter` typing should really be `delimiter: str = '/',` though. I think we've been getting away with this in mypy for a while 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org