[GitHub] [systemds] fathollahzadeh commented on pull request #1232: [DISLIBSVM] Add Distributed Read/Write LIBSVM on Spark

[GitBox <gi...@apache.org>]

fathollahzadeh commented on pull request #1232:
URL: https://github.com/apache/systemds/pull/1232#issuecomment-831155486


   > Thanks, @fathollahzadeh for fixing the space issues. I had a look into the changes and it already looks quite good. However, it would be great if you can fix the automatic application of code style to all the files. Currently, it is very hard to spot the actual changes done by your commits. In addition to that, the code style introduced some weird formatting all over the common files. Other than that, the file VariableCPInstruction.java still has spaces instead of tabs.
   > Meanwhile, I will try to have a detailed look into the changes, run some tests, rebase, resolve the conflicts and make a commit to run the tests in github.
   
   Thanks, @phaniarnab  for the review. I remove all unnecessary code styles in changed files. Now, the code style applied just for the task updates.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org