[jira] [Commented] (MGPG-125) Due to default value of gpg.passphraseServerId, bestPractices=true will always fail

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836166#comment-17836166 ] 

ASF GitHub Bot commented on MGPG-125:
-------------------------------------

cstamas opened a new pull request, #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95

   As currently due defaulted values it would always fail, unless user explicitly re-configures plugin. So, do not set "default value" on mojo level, instead handle it programmatically, when bestPractices is not set.
   
   ---
   
   https://issues.apache.org/jira/browse/MGPG-125




> Due to default value of gpg.passphraseServerId, bestPractices=true will always fail
> -----------------------------------------------------------------------------------
>
>                 Key: MGPG-125
>                 URL: https://issues.apache.org/jira/browse/MGPG-125
>             Project: Maven GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 3.2.3
>            Reporter: Benjamin Marwell
>            Priority: Critical
>             Fix For: 3.2.4
>
>
> Running gpg-plugin with best practices from the CLI, it will always fail since gpg.passphraseServerId does have a default value set.
> See:
> https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140
> CC [~cstamas]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)