You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/12/06 14:52:44 UTC
Review Request 41020: If a non-hdfs path is specified (such as wasb)
as the hbase.rootdir then stack advisor throws error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41020/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-14234
https://issues.apache.org/jira/browse/AMBARI-14234
Repository: ambari
Description
-------
hbase.rootdir = wasb:///ams/hbase
hdiuser@hn1-mnaina:~$ cat /var/run/ambari-server/stack-recommendations/32/stackadvisor.err
Traceback (most recent call last):
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
main(sys.argv)
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 115, in main
result = stackAdvisor.validateConfigurations(services, hosts)
File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 463, in validateConfigurations
validationItems = self.getConfigurationsValidationItems(services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 743, in getConfigurationsValidationItems
resultItems = method(siteProperties, siteRecommendations, configurations, services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 848, in validateAmsHbaseSiteConfigurations
validationItems.extend([{"config-name": 'hbase.rootdir', "item": self.validatorEnoughDiskSpace(properties, 'hbase.rootdir', host["Hosts"], recommendedDiskSpace)}])
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 1121, in validatorEnoughDiskSpace
if mountPoints[mountPoint] < reqiuredDiskSpace:
KeyError: None
- Copy core-site and hdfs-site, only when AMS mode is set to distributed, since product doc says distributed = HDFS
- Beyond this point HBase protocol can be dictated by fs.defaultFS and hbase.rootdir without us in the middle interpreting things
- In the stack advisor as well we can rely on the mode of operation to determine whether local FS check should be performed
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 615e93a
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py ec5e848
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9d9e0dd
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c946d42
Diff: https://reviews.apache.org/r/41020/diff/
Testing
-------
Unit tests passed
----------------------------------------------------------------------
Ran 250 tests in 8.166s
OK
----------------------------------------------------------------------
Total run:849
Total errors:0
Total failures:0
OK
Thanks,
Dmytro Sen
Re: Review Request 41020: If a non-hdfs path is specified (such as
wasb) as the hbase.rootdir then stack advisor throws error
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41020/#review109098
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 6, 2015, 3:52 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41020/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 3:52 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-14234
> https://issues.apache.org/jira/browse/AMBARI-14234
>
>
> Repository: ambari
>
>
> Description
> -------
>
> hbase.rootdir = wasb:///ams/hbase
> hdiuser@hn1-mnaina:~$ cat /var/run/ambari-server/stack-recommendations/32/stackadvisor.err
> Traceback (most recent call last):
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
> main(sys.argv)
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 115, in main
> result = stackAdvisor.validateConfigurations(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 463, in validateConfigurations
> validationItems = self.getConfigurationsValidationItems(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 743, in getConfigurationsValidationItems
> resultItems = method(siteProperties, siteRecommendations, configurations, services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 848, in validateAmsHbaseSiteConfigurations
> validationItems.extend([{"config-name": 'hbase.rootdir', "item": self.validatorEnoughDiskSpace(properties, 'hbase.rootdir', host["Hosts"], recommendedDiskSpace)}])
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 1121, in validatorEnoughDiskSpace
> if mountPoints[mountPoint] < reqiuredDiskSpace:
> KeyError: None
>
> - Copy core-site and hdfs-site, only when AMS mode is set to distributed, since product doc says distributed = HDFS
> - Beyond this point HBase protocol can be dictated by fs.defaultFS and hbase.rootdir without us in the middle interpreting things
> - In the stack advisor as well we can rely on the mode of operation to determine whether local FS check should be performed
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 615e93a
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py ec5e848
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9d9e0dd
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c946d42
>
> Diff: https://reviews.apache.org/r/41020/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> ----------------------------------------------------------------------
> Ran 250 tests in 8.166s
>
> OK
> ----------------------------------------------------------------------
> Total run:849
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>