You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/24 04:36:02 UTC
[GitHub] [echarts-doc] xiaoyueguang opened a new pull request #183: doc: add series.heatmap.strictlyAligned
xiaoyueguang opened a new pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183
Relates [fix(heatmap): add option for align in heatmap](https://github.com/apache/echarts/pull/14779)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang commented on a change in pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#discussion_r619742904
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,9 @@
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
+
+**注意**：此配置生效后，在数据量很大时可能会有性能问题。
Review comment:
Hi, can you put an example of how this can cause performance issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] xiaoyueguang commented on a change in pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
xiaoyueguang commented on a change in pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#discussion_r619787619
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,9 @@
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
+
+**注意**：此配置生效后，在数据量很大时可能会有性能问题。
Review comment:
I remember that CANVAS has an optimization to ensure that the number is an integer, So I came to the conclusion.
This is MDN docs.
[MDN](https://developer.mozilla.org/zh-CN/docs/Web/API/Canvas_API/Tutorial/Optimizing_canvas#%E9%81%BF%E5%85%8D%E6%B5%AE%E7%82%B9%E6%95%B0%E7%9A%84%E5%9D%90%E6%A0%87%E7%82%B9%EF%BC%8C%E7%94%A8%E6%95%B4%E6%95%B0%E5%8F%96%E8%80%8C%E4%BB%A3%E4%B9%8B)
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,9 @@
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
+
+**注意**：此配置生效后，在数据量很大时可能会有性能问题。
Review comment:
i create a [DEMO](https://github.com/xiaoyueguang/echarts-heatmap-demo).
After the test, the performance is not bad.
So do i remove this notice? @pissang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] xiaoyueguang commented on pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
xiaoyueguang commented on pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#issuecomment-826042178
> Please add `version` if this were accepted.
Sorry, I don`t know what version add.
I found this [commit](https://github.com/apache/echarts-doc/commit/f5c6331a3290638116547f87a993bb76e639c6ae)
So 5.1.2 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] xiaoyueguang commented on a change in pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
xiaoyueguang commented on a change in pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#discussion_r619999146
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,9 @@
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
+
+**注意**：此配置生效后，在数据量很大时可能会有性能问题。
Review comment:
i create a [DEMO](https://github.com/xiaoyueguang/echarts-heatmap-demo).
After the test, the performance is not bad.
So do i remove this notice? @pissang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] Rain120 commented on a change in pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
Rain120 commented on a change in pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#discussion_r819296749
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,12 @@
+
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+{{ use: partial-version(
+ version = '5.2.0'
+) }}
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
Review comment:
Are you forget to translate here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] xiaoyueguang commented on a change in pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
xiaoyueguang commented on a change in pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#discussion_r619787619
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,9 @@
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
+
+**注意**：此配置生效后，在数据量很大时可能会有性能问题。
Review comment:
I remember that CANVAS has an optimization to ensure that the number is an integer, So I came to the conclusion.
This is MDN docs.
[MDN](https://developer.mozilla.org/zh-CN/docs/Web/API/Canvas_API/Tutorial/Optimizing_canvas#%E9%81%BF%E5%85%8D%E6%B5%AE%E7%82%B9%E6%95%B0%E7%9A%84%E5%9D%90%E6%A0%87%E7%82%B9%EF%BC%8C%E7%94%A8%E6%95%B4%E6%95%B0%E5%8F%96%E8%80%8C%E4%BB%A3%E4%B9%8B)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang commented on a change in pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#discussion_r619742904
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,9 @@
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
+
+**注意**：此配置生效后，在数据量很大时可能会有性能问题。
Review comment:
Hi, can you put an example of how this can cause performance issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang commented on a change in pull request #183: doc: add series.heatmap.strictlyAligned
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #183:
URL: https://github.com/apache/echarts-doc/pull/183#discussion_r620033299
##########
File path: zh/option/partial/strictly-aligned.md
##########
@@ -0,0 +1,9 @@
+{{ target: partial-strictly-aligned }}
+
+## strictlyAligned(boolean) = false
+
+强制线条对齐，在笛卡尔坐标系([coordinateSystem](~series-heatmap.coordinateSystem): 'cartesian2d')上有效。
+
+**注意**：此配置生效后，在数据量很大时可能会有性能问题。
Review comment:
I'm not sure. Performance optimization can be outdated. If the benchmark shows the performance is similar, we can remove this notice to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org