You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/08 19:53:59 UTC
[jira] [Commented] (TINKERPOP-1547) Two bugs found associated with
MatchStep: Path retraction and range count.
[ https://issues.apache.org/jira/browse/TINKERPOP-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648617#comment-15648617 ]
ASF GitHub Bot commented on TINKERPOP-1547:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/483
TINKERPOP-1547: Two bugs found associated with MatchStep: Path retraction and range count.
https://issues.apache.org/jira/browse/TINKERPOP-1547
Two bugs had always existed because we had commented out tests due to their failure. Fixed the bugs and exposed more tests. Also, some `match()` benchmarks got faster. Finally, I found a bug in `MatchStep.clone()` that only makes itself apparent (and randomly) when there is a `match()`-step within a local child of an OLAP traversal with single processor threading.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1547
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit e6266b12a0c90a7283231d2d435d1d677baccbfa
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-11-08T17:02:37Z
fixed a bug in MatchStep that I forgot we had. Because of it, we had 3 tests commented out. Doh. The tests were a combination of problems in PathRetractionsStrategy and RangeByIsCountStratyegy. Because of the fix in PathRetractionStrategy, some match benchmarks got significantly faster.
commit 56e113da4878eb4e082b8589d323cbfa4efd31ac
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-11-08T18:56:30Z
updated CHANGELOG and fixed a MatchStep.clone() bug that exposes itself in OLAP traversals with OLTP match() children.
----
> Two bugs found associated with MatchStep: Path retraction and range count.
> --------------------------------------------------------------------------
>
> Key: TINKERPOP-1547
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1547
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.3
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Fix For: 3.2.4
>
>
> {{PathRetractionStrategy}} can retract end labels from traversals and thus, ruin a pattern match. We had 3 traversals in our test suite that were buggy because of this. Finally, if the user does a pattern of {{as("a").count().is(gt(10)).as("b")}}, this will fail because of {{RangeIsCountByStrategy}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)