You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benjamin Lerer (Jira)" <ji...@apache.org> on 2020/10/08 12:35:00 UTC
[jira] [Commented] (CASSANDRA-16184) ClientRequestSize metric tests
should be improved
[ https://issues.apache.org/jira/browse/CASSANDRA-16184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210180#comment-17210180 ]
Benjamin Lerer commented on CASSANDRA-16184:
--------------------------------------------
[PR|https://github.com/apache/cassandra/pull/769], [J8-CI|https://app.circleci.com/pipelines/github/blerer/cassandra/37/workflows/67f01cdf-edc1-463a-a6f0-61ced8abe01b], [J11-CI|https://app.circleci.com/pipelines/github/blerer/cassandra/37/workflows/cdc78382-e2b2-4ba1-a7ee-af8b8aa416fd]
> ClientRequestSize metric tests should be improved
> -------------------------------------------------
>
> Key: CASSANDRA-16184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16184
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Priority: Normal
> Fix For: 4.0-beta
>
>
> The current test for {{ClientRequestSize}} only test that the metrics are updated on request. It does not test that the returned values are the expected ones. Some test comparisons are done with the wrong values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org