You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/05/11 13:24:45 UTC

[PR] fix(ux): use title case for button labels [superset]

aminghadersohi opened a new pull request, #40022:
URL: https://github.com/apache/superset/pull/40022

### SUMMARY

Replaces ALL CAPS button labels with Title Case to align with the Superset design system convention. Six labels across five files were using uppercase strings that violate the established button label style.

Changes:
- `DateFilterLabel.tsx`: `CANCEL` → `Cancel`, `APPLY` → `Apply`
- `AnnotationLayer.tsx`: `OK` → `Confirm`
- `DatasourceModal/index.tsx`: `OK` → `Confirm`
- `Tabs.tsx`: `DELETE` → `Delete`
- `ResultSet/index.tsx`: `OK` → `Confirm`

### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Button labels displayed in ALL CAPS (e.g. CANCEL, APPLY, OK, DELETE)
After: Button labels displayed in Title Case (e.g. Cancel, Apply, Confirm, Delete)

### TESTING INSTRUCTIONS

1. Open the Date Filter control → verify Cancel and Apply buttons are title case
2. Open an Annotation Layer → verify the submit button shows "Confirm"
3. Open a Datasource modal and trigger the confirm save dialog → verify "Confirm" button
4. On a dashboard with tabs, delete a tab → verify the danger button shows "Delete"
5. In SQL Lab, run a large query and export → verify the confirmation dialog shows "Confirm"

### ADDITIONAL INFORMATION

- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ux): use title case for button labels [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.

bito-code-review[bot] commented on PR #40022:
URL: https://github.com/apache/superset/pull/40022#issuecomment-4421111010

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ux): use title case for button labels [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.

bito-code-review[bot] commented on code in PR #40022:
URL: https://github.com/apache/superset/pull/40022#discussion_r3219463525


##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -328,7 +328,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
           onClick={onHide}
           data-test={DateFilterTestKey.CancelButton}
         >
-          {t('CANCEL')}
+          {t('Cancel')}

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Test expectation mismatch</b></div>
   <div id="fix">
   
   Update DateFilterLabel.test.tsx to expect 'Cancel' instead of 'CANCEL' and 'Apply' instead of 'APPLY' in the popover tests.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #ee6107</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ux): use title case for button labels [superset]

Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.

kasiazjc closed pull request #40022: fix(ux): use title case for button labels
URL: https://github.com/apache/superset/pull/40022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ux): use title case for button labels [superset]

Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.

kasiazjc commented on PR #40022:
URL: https://github.com/apache/superset/pull/40022#issuecomment-4430203909

   Closing to reopen under the correct author (kasiazjc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org