You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "renatoh (via GitHub)" <gi...@apache.org> on 2026/06/29 15:26:19 UTC
[PR] follow up to PR#4406: read only from localParams and do not read mmAu… [solr]
renatoh opened a new pull request, #4568:
URL: https://github.com/apache/solr/pull/4568
following up on the comments by @dsmiley on the already merged PR https://github.com/apache/solr/pull/4406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] follow up to PR#4406: read only from localParams and do not read mmAu… [solr]
Posted by "renatoh (via GitHub)" <gi...@apache.org>.
renatoh commented on PR #4568:
URL: https://github.com/apache/solr/pull/4568#issuecomment-4863181589
> Thanks Renatoh
Thanks you, our constant feedback is very much appreciate!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] follow up to PR#4406: read only from localParams and do not read mmAu… [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4568:
URL: https://github.com/apache/solr/pull/4568#issuecomment-4860188407
Thanks Renatoh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] follow up to PR#4406: read only from localParams and do not read mmAu… [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #4568:
URL: https://github.com/apache/solr/pull/4568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] follow up to PR#4406: read only from localParams and do not read mmAu… [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4568:
URL: https://github.com/apache/solr/pull/4568#issuecomment-4855776130
Right; we put backwards-compatibility high on our values in Solr. We do make exceptions, say a security matter. Or if maybe a change is judged very obscure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] follow up to PR#4406: read only from localParams and do not read mmAu… [solr]
Posted by "renatoh (via GitHub)" <gi...@apache.org>.
renatoh commented on PR #4568:
URL: https://github.com/apache/solr/pull/4568#issuecomment-4851185342
> While I like the fix relating to minShouldMatch, as it's non-released... I'm hesitant to approve the `clauses()` as this is technically a change to existing behavior, even if I'm somewhat suspicious someone depends on this behavior. It's really unfortunate Solr doesn't have a consistent/unified approach to parameter resolution that all users can understand. Instead, each QP makes its own decision on how each param is resolved. :-(
I see you point. I changed it because what I got from one of your earlier comments is that BoolQParser should read only localParams, and not params. Such a change is only possible in a major version since it's technically breaking backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org