[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #788: HUDI-168 Ensure getFileStatus calls for files getting written happens after close() is called

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #788: HUDI-168 Ensure getFileStatus calls for files getting written happens after close() is called
URL: https://github.com/apache/incubator-hudi/pull/788#discussion_r303690624
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/table/HoodieMergeOnReadTable.java
 ##########
 @@ -527,6 +525,10 @@ private HoodieRollbackStat rollback(HoodieIndex hoodieIndex, String partitionPat
               if (writer != null) {
                 writer.close();
               }
+              if (success) {
 
 Review comment:
   @n3nash @vinothchandar : Added documentation the reason for this change
   
   @vinothchandar : This writer.close() part is in finally() block. I am not sure if we need to update filesToNumBlocksRollback if writer.close() fails as the rollback would fail in that case. If still needed, would be fine with adding. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services