You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "damian.golda@gmail.com (JIRA)" <ji...@apache.org> on 2009/01/20 17:59:59 UTC
[jira] Created: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
------------------------------------------------------------------------------------------------
Key: CAMEL-1278
URL: https://issues.apache.org/activemq/browse/CAMEL-1278
Project: Apache Camel
Issue Type: Bug
Components: camel-velocity
Affects Versions: 1.5.0
Reporter: damian.golda@gmail.com
VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
The reason is that there is used InputStreamReader constructor without encoding parameter.
I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Anstey reassigned CAMEL-1278:
--------------------------------------
Assignee: Jonathan Anstey
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: damian.golda@gmail.com
> Assignee: Jonathan Anstey
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48848#action_48848 ]
Jonathan Anstey commented on CAMEL-1278:
----------------------------------------
Haha! Beat you to it, wiki police ;)
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: damian.golda@gmail.com
> Assignee: Jonathan Anstey
> Fix For: 1.5.1, 2.0.0
>
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48845#action_48845 ]
Jonathan Anstey commented on CAMEL-1278:
----------------------------------------
Updated the wiki here as well http://cwiki.apache.org/confluence/display/CAMEL/Velocity
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: damian.golda@gmail.com
> Assignee: Jonathan Anstey
> Fix For: 1.5.1, 2.0.0
>
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "Damian Gołda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48865#action_48865 ]
Damian Gołda commented on CAMEL-1278:
-------------------------------------
Jonathan, thank you for very quick action. I'm impressed.
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: Damian Gołda
> Assignee: Jonathan Anstey
> Fix For: 1.5.1, 2.0.0
>
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Anstey resolved CAMEL-1278.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
1.5.1
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: damian.golda@gmail.com
> Assignee: Jonathan Anstey
> Fix For: 1.5.1, 2.0.0
>
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "damian.golda@gmail.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
damian.golda@gmail.com updated CAMEL-1278:
------------------------------------------
Attachment: VelocityEndpoint.diff
Patch to VelocityEndpoint.java
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: damian.golda@gmail.com
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48844#action_48844 ]
Jonathan Anstey commented on CAMEL-1278:
----------------------------------------
I've committed your changes in revision 736046. Thanks for the contribution Damian! I also added a little unit test for this new option.
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: damian.golda@gmail.com
> Assignee: Jonathan Anstey
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1278) VelocityEndpoint reads velocity
templates using default encoding - add parameter to set encoding
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48846#action_48846 ]
Claus Ibsen commented on CAMEL-1278:
------------------------------------
Remember to update the wiki
> VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding
> ------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1278
> URL: https://issues.apache.org/activemq/browse/CAMEL-1278
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-velocity
> Affects Versions: 1.5.0
> Reporter: damian.golda@gmail.com
> Assignee: Jonathan Anstey
> Fix For: 1.5.1, 2.0.0
>
> Attachments: VelocityEndpoint.diff
>
>
> VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.
> The reason is that there is used InputStreamReader constructor without encoding parameter.
> I've added simple support for setting encoding - see attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.