You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Alwaysgaurav1 (via GitHub)" <gi...@apache.org> on 2026/07/06 06:50:28 UTC
[PR] fix(execution-api): support connection IDs with slashes in get_connection route [airflow]
Alwaysgaurav1 opened a new pull request, #69439:
URL: https://github.com/apache/airflow/pull/69439
### Description
The Execution API endpoint `GET /execution/connections/{connection_id}` uses a standard path parameter `{connection_id}`, which causes FastAPI to treat slashes in connection IDs as path separators. This means connection IDs containing slashes (e.g. `my/slashed/conn`) return a 404 Not Found instead of resolving correctly.
This is inconsistent with the Variables endpoint which already uses `{variable_key:path}` to support keys with slashes.
This PR fixes the issue by changing the route definition from `/{connection_id}` to `/{connection_id:path}`, allowing connection IDs with slashes to be properly resolved.
A new unit test `test_connection_get_with_slash` is added to verify that connections with slashed IDs can be fetched successfully.
Closes: #57864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(execution-api): support connection IDs with slashes in get_connection route [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #69439: fix(execution-api): support connection IDs with slashes in get_connection route
URL: https://github.com/apache/airflow/pull/69439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(execution-api): support connection IDs with slashes in get_connection route [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #69439:
URL: https://github.com/apache/airflow/pull/69439#discussion_r3550777611
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/connections.py:
##########
@@ -57,7 +57,7 @@ async def has_connection_access(
@router.get(
- "/{connection_id}",
+ "/{connection_id:path}",
Review Comment:
Can you also make the respective changes for the task sdk client? Check #57864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org