You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/12 20:34:23 UTC
[GitHub] [knox] risdenk commented on a change in pull request #263: [WIP]
KNOX-2226 - Add home page to Knox
risdenk commented on a change in pull request #263: [WIP] KNOX-2226 - Add home page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r378491084
##########
File path: gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java
##########
@@ -923,6 +925,40 @@ private synchronized void internalActivateArchive( Topology topology, File warDi
}
}
+ private synchronized void activateHomeApp() {
+ try {
+ // UI
+ activateHomepageContext("/home", "homepage/%2Fhome");
+
+ // API
+ activateHomepageContext("/home/api", "homepage/%2F");
+ } catch (Throwable e) {
+ e.printStackTrace();
Review comment:
remove `e.printStackTrace()`
why are we catching `Throwable` that seems bad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services