You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/01/30 09:40:56 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #3399: make
ConfigChangeEvent immutable
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3399?src=pr&el=h1) Report
> Merging [#3399](https://codecov.io/gh/apache/incubator-dubbo/pull/3399?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/dd2e16b6ddcc6aa545b9021370ae0855ae0647f8?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3399?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3399 +/- ##
============================================
+ Coverage 63.75% 63.85% +0.09%
Complexity 71 71
============================================
Files 661 661
Lines 28602 28600 -2
Branches 4806 4821 +15
============================================
+ Hits 18236 18262 +26
+ Misses 8134 8118 -16
+ Partials 2232 2220 -12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3399?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...stry/integration/AbstractConfiguratorListener.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9BYnN0cmFjdENvbmZpZ3VyYXRvckxpc3RlbmVyLmphdmE=) | `30.76% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `39.5% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ster/router/condition/config/ListenableRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVJvdXRlci5qYXZh) | `33.33% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ter/support/apollo/ApolloDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L2Fwb2xsby9BcG9sbG9EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../configcenter/support/zookeeper/CacheListener.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9DYWNoZUxpc3RlbmVyLmphdmE=) | `68.42% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/configcenter/DefaultConfigChangeEvent.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9EZWZhdWx0Q29uZmlnQ2hhbmdlRXZlbnQuamF2YQ==) | `43.75% <43.75%> (ø)` | `0 <0> (?)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...che/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29tcGlsZXIvc3VwcG9ydC9KZGtDb21waWxlci5qYXZh) | `64.54% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3399/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3399?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3399?src=pr&el=footer). Last update [dd2e16b...bab6b04](https://codecov.io/gh/apache/incubator-dubbo/pull/3399?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3399 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org