You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/05 13:38:51 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1655: Fineract 982ditchdrizzle
francisguchie opened a new pull request #1655:
URL: https://github.com/apache/fineract/pull/1655
## Description
Please read details here #1650
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
Just a brief
Fineract's use of the un-maintained Drizzle JDBC driver continues to cause confusion and pains like FINERACT-980, and note e.g. the proposed removal of the alternative MySQL JDBC driver in https://github.com/apache/fineract/pull/887.
Some of the background to this is recorded e.g. in FINCN-26, FINERACT-761 and LEGAL-462.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on a change in pull request #1655: Fineract 982ditchdrizzle
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #1655:
URL: https://github.com/apache/fineract/pull/1655#discussion_r588875037
##########
File path: fineract-provider/dependencies.gradle
##########
@@ -61,6 +61,7 @@ dependencies {
'org.apache.poi:poi-ooxml-schemas',
'org.apache.tika:tika-core',
+ 'mysql:mysql-connector-java:8.0.23',
'org.drizzle.jdbc:drizzle-jdbc',
Review comment:
We still face a problem of packaging here as we cannot distribute fineract with mysql connector. That is the main problem to this issue. This adds an additional connector jar but the system is still using drizzle connector. The whole point here is to completely remove drizzle and use mysql/mariadb connector while avoiding to include it the fineract jar as breaches apache licence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1655: Fineract 982ditchdrizzle
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1655:
URL: https://github.com/apache/fineract/pull/1655
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1655: Fineract 982ditchdrizzle
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1655:
URL: https://github.com/apache/fineract/pull/1655#discussion_r589733263
##########
File path: fineract-provider/dependencies.gradle
##########
@@ -61,6 +61,7 @@ dependencies {
'org.apache.poi:poi-ooxml-schemas',
'org.apache.tika:tika-core',
+ 'mysql:mysql-connector-java:8.0.23',
'org.drizzle.jdbc:drizzle-jdbc',
Review comment:
I agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1655: Fineract 982ditchdrizzle
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1655:
URL: https://github.com/apache/fineract/pull/1655#issuecomment-793605561
@xurror @vorburger
For me, every day with this great team is learning process, and i am enjoying the ride. Thank you for this insight I think i over looked the licensing lessons i learnt a few months back (about the Pentaho issue) about the licensing under ASF
I agree too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1655: Fineract 982ditchdrizzle
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1655:
URL: https://github.com/apache/fineract/pull/1655#discussion_r589139138
##########
File path: fineract-provider/dependencies.gradle
##########
@@ -61,6 +61,7 @@ dependencies {
'org.apache.poi:poi-ooxml-schemas',
'org.apache.tika:tika-core',
+ 'mysql:mysql-connector-java:8.0.23',
'org.drizzle.jdbc:drizzle-jdbc',
Review comment:
I think we should first get FINERACT-1177 (#1646) merged; after that above problem will be a lot easier to solve, because we'll be able to just drop external drivers like Mysql Connector or MariaDB in a folder next to the fineract-provider Spring Boot uber-jar. FINERACT-1177 doesn't require any editing of fineract-provider/dependencies.gradle. I think this is important, because as soon as we have any non-compliant JARs referenced in any \*.gradle file we are not compliant with the Apache License anymore (my 2cents, I'm not a lawyer).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1655: Fineract 982ditchdrizzle
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1655:
URL: https://github.com/apache/fineract/pull/1655#issuecomment-791449165
Any ideas why this is failing?
```
CenterIntegrationTest > testCenterDeletion() FAILED
org.opentest4j.AssertionFailedError: /fineract-provider/actuator/health returned <html lang="en">
<head>
<title>HTTP Status 404 – Not Found</title>
<style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style>
</head>
<body>
<h1>HTTP Status 404 – Not Found</h1>
<hr class="line"/>
<p>
<b>Type</b>
Status Report </p>
<p>
<b>Description</b>
The origin server did not find a current representation for the target resource or is not willing to disclose that one exists. </p>
<hr class="line"/>
<h3>Apache Tomcat/9.0.43</h3>
</body>
</html>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
at org.junit.jupiter.api.Assertions.fail(Assertions.java:117)
at org.apache.fineract.integrationtests.common.Utils.awaitSpringBootActuatorHealthyUp(Utils.java:105)
at org.apache.fineract.integrationtests.common.Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey(Utils.java:119)
at org.apache.fineract.integrationtests.CenterIntegrationTest.setup(CenterIntegrationTest.java:54)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1655: Fineract 982ditchdrizzle
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1655:
URL: https://github.com/apache/fineract/pull/1655#issuecomment-791789020
> Any ideas why this is failing?
>
> ```
> CenterIntegrationTest > testCenterDeletion() FAILED
>
> org.opentest4j.AssertionFailedError: /fineract-provider/actuator/health returned <html lang="en">
>
> <head>
>
> <title>HTTP Status 404 – Not Found</title>
>
> <style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style>
>
> </head>
>
> <body>
>
> <h1>HTTP Status 404 – Not Found</h1>
>
> <hr class="line"/>
>
> <p>
>
> <b>Type</b>
>
> Status Report </p>
>
> <p>
>
> <b>Description</b>
>
> The origin server did not find a current representation for the target resource or is not willing to disclose that one exists. </p>
>
> <hr class="line"/>
>
> <h3>Apache Tomcat/9.0.43</h3>
>
> </body>
>
> </html>
>
> at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
>
> at org.junit.jupiter.api.Assertions.fail(Assertions.java:117)
>
> at org.apache.fineract.integrationtests.common.Utils.awaitSpringBootActuatorHealthyUp(Utils.java:105)
>
> at org.apache.fineract.integrationtests.common.Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey(Utils.java:119)
>
> at org.apache.fineract.integrationtests.CenterIntegrationTest.setup(CenterIntegrationTest.java:54)
> ```
@vidakovic some builds will come with failed intergration tests not necessarily arising from ones PR.
Nevertheless, at the moment i have no idea why it is failing let us hear from others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org