[GitHub] [pulsar] yuruguo commented on a diff in pull request #17337: [broker][admin] Add cmd to remove topic properties

[GitBox <gi...@apache.org>]

yuruguo commented on code in PR #17337:
URL: https://github.com/apache/pulsar/pull/17337#discussion_r958270130


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -655,6 +655,57 @@ public void updatePropertiesFailed(ManagedLedgerException exception, Object ctx)
         return future;
     }
 
+    protected CompletableFuture<Void> internalRemovePropertiesAsync(boolean authoritative, String key) {
+        return validateTopicOwnershipAsync(topicName, authoritative)
+                .thenCompose(__ -> validateNamespaceOperationAsync(topicName.getNamespaceObject(),
+                        NamespaceOperation.CREATE_TOPIC))

Review Comment:
   `Properties` are set when topic is created and it need `NamespaceOperation.CREATE_TOPIC` permission, which correspond to `super user` or `tenant administrator`. 
   So I think only roles with above permission are allowed to delete properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org