You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/29 03:19:59 UTC

[PR] test(amber): cover the end-channel and retry handlers and the range partitioner [texera]

aglinxinyuan opened a new pull request, #8088:
URL: https://github.com/apache/texera/pull/8088

   ### What changes were proposed in this PR?
   
   Two new specs and one extended, taking the three files from 4 tests to 20.
   
   | File | Codecov lines | Branch arms |
   |---|---|---|
   | `RetryWorkflowHandler.scala` | 1/5 → **5/5** | no branches |
   | `EndChannelHandler.scala` | 14/19 → **18/19** | 4/10 → **8/10** |
   | `RangeBasedShufflePartitioner.scala` | 17/21 → **20/21** | 9/30 → 10/30 |
   
   **+11 fully-covered lines and +5 branch arms.** JaCoCo line-hit moves +8 (the two metrics differ because three of the gained lines were already line-hit and flip only by completing a second arm).
   
   ### Two files from the original scope contribute nothing, and are named rather than quietly dropped
   
   - **`DataProcessorRPCHandlerInitializer`** — the nominated target of this bundle — measured **8/15 before and 8/15 after**. Its only real logic is already covered, and its five remaining lines are `???` stubs that the existing spec deliberately declined to pin.
   - **`OutputManager`** stays at 98/108. Its storage path looked like the single biggest opportunity here (~18 lines) and it is already covered by the `DataProcessingSpec` end-to-end workflows, which provision real result and state documents.
   
   The assessment put this bundle at 25 lines and 15 arms. **It delivered 11 and 5.** The gap was almost entirely one file: `RangeBasedShufflePartitioner` was assessed at +16 on a claimed 4/21 baseline, but the real baseline is 17/21 because **a spec already exists** — `RangeBasedShuffleSpec.scala`, under `messaginglayer` rather than the mirrored `sendsemantics/partitioners` path and without "Partitioner" in its name, which is why a class-name search missed it. That spec was extended in place rather than a duplicate created, and the real win there is +3.
   
   ### `retryWorkflow` has no caller in main
   
   `RetryWorkflowHandler.retryWorkflow` is invoked from nowhere in `main`. It exists as the declared `rpc RetryWorkflow(RetryWorkflowRequest)` endpoint in `coordinatorservice.proto`, so it is a live API surface rather than dead internal code — but the new spec pins the **RPC contract**, not observed production behaviour, and that distinction is worth stating before someone reads 1/5 → 5/5 as covering a hot path.
   
   ### Verification
   
   **One survivor, reported rather than killed or dressed up as equivalent.** Exchanging `getAllPorts.forall(portId => isPortCompleted(portId))` for `getAllPorts.forall(p => getPort(p).completed)` at `EndChannelHandler:64` **survives** — measured twice. These are genuinely different predicates: `InputManager.isPortCompleted` branches, and for a port fed from materialization it returns the reader *thread's* `finished` flag and ignores `.completed` entirely. The fixture registers both input ports with empty URI lists, so only the non-materialization branch is ever reachable. Closing it needs storage-backed input ports or a widened private — a production change, refused. **This is an out-of-reach mutant, not an equivalent one**, and the spec's own scaladoc says so, so the next reader does not mistake the two-port fixture for full coverage of the completion predicate.
   
   **`EndChannelHandler:54` can never become a fully-covered line** and is not counted as one. It moves 0/4 → 2/4 arms. The two dead arms are the `catch pf` isDefinedAt-false rethrow — dead because `ErrorUtils.safely` returns a *total* PartialFunction — and the `$outer` null guard in the generated anonfun's constructor.
   
   Two adversarial reviewers returned ten findings; all repaired. One correction worth naming: two assertions of the form `command == EmptyRequest()` were **guaranteed by the generated type** — `controlcommands.proto:75` is literally `message EmptyRequest{}` with no fields, so every instance equals every other. They were removed rather than left looking like constraints.
   
   Measured with one fresh sbt JVM per side, the jacoco directory removed between runs, scoped by **suite name** via a byte-identical throwaway `.sbt` filter that was deleted afterwards. The before-state restored the extended spec with `git show HEAD:<path>` and deleted the two new files — never `git checkout --` — with the final specs sha1-snapshotted first and sha1-verified on restore. Before: 59 suites / 492 tests, 0 failures. After: 61 suites / 508 tests, 0 failures.
   
   No production file is touched; `git diff -- '*/src/main/*'` is empty.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8087
   
   ### How was this PR tested?
   
   ```
   sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.worker.promisehandlers.EndChannelHandlerSpec org.apache.texera.amber.engine.architecture.coordinator.promisehandlers.RetryWorkflowHandlerSpec org.apache.texera.amber.engine.architecture.messaginglayer.RangeBasedShuffleSpec"
   ```
   
   ```
   [info] Total number of tests run: 20
   [info] Tests: succeeded 20, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   ```
   
   `WorkflowExecutionService/Test/scalafmtCheck` and `WorkflowExecutionService/Test/scalafix --check` both pass. Re-run after rebasing onto current `main`.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): cover the end-channel and retry handlers and the range partitioner [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8088:
URL: https://github.com/apache/texera/pull/8088#issuecomment-5460015324

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@Yicong-Huang`
     You can notify them by mentioning `@Yicong-Huang` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): cover the end-channel and retry handlers and the range partitioner [texera]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #8088:
URL: https://github.com/apache/texera/pull/8088#discussion_r3885868793


##########
amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/promisehandlers/EndChannelHandlerSpec.scala:
##########
@@ -0,0 +1,446 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.texera.amber.engine.architecture.worker.promisehandlers
+
+import com.twitter.util.{Await, Duration, Future}
+import org.apache.texera.amber.core.executor.OperatorExecutor
+import org.apache.texera.amber.core.state.State
+import org.apache.texera.amber.core.tuple.{
+  AttributeType,
+  FinalizeExecutor,
+  FinalizePort,
+  Schema,
+  Tuple,
+  TupleLike
+}
+import org.apache.texera.amber.core.virtualidentity.{
+  ActorVirtualIdentity,
+  ChannelIdentity,
+  OperatorIdentity,
+  PhysicalOpIdentity
+}
+import org.apache.texera.amber.core.workflow.{PhysicalLink, PortIdentity}
+import org.apache.texera.amber.engine.architecture.rpc.controlcommands.{
+  AsyncRPCContext,
+  ConsoleMessageTriggeredRequest,
+  ControlInvocation,
+  EmptyRequest
+}
+import org.apache.texera.amber.engine.architecture.rpc.controlreturns.EmptyReturn
+import org.apache.texera.amber.engine.architecture.sendsemantics.partitionings.OneToOnePartitioning
+import org.apache.texera.amber.engine.architecture.worker.WorkflowWorker.{
+  DPInputQueueElement,
+  MainThreadDelegateMessage
+}
+import org.apache.texera.amber.engine.architecture.worker.{
+  DataProcessor,
+  DataProcessorRPCHandlerInitializer,
+  OperatorLogicPause,
+  UserPause
+}
+import org.apache.texera.amber.engine.common.ambermessage.{StateFrame, WorkflowFIFOMessage}
+import org.apache.texera.amber.engine.common.virtualidentity.util.COORDINATOR
+import org.scalatest.flatspec.AnyFlatSpec
+
+import java.util.concurrent.LinkedBlockingQueue
+import scala.collection.mutable.ArrayBuffer
+import scala.util.control.ControlThrowable
+
+/**
+  * `endChannel` runs on a worker when the END_CHANNEL embedded control message reaches it, i.e.
+  * when one input channel has delivered everything it will ever deliver. It is the mirror of
+  * [[StartChannelHandlerSpec]]'s handler and does four things:
+  *

Review Comment:
   Scaladoc says the handler "does four things" but the list enumerates five steps (1–5). This is internally inconsistent and can confuse readers.



##########
amber/src/test/scala/org/apache/texera/amber/engine/architecture/messaginglayer/RangeBasedShuffleSpec.scala:
##########
@@ -126,7 +136,74 @@ class RangeBasedShuffleSpec extends AnyFlatSpec with MockFactory {
     val longSchema: Schema = Schema().add(longAttr)
     tuple = Tuple.builder(longSchema).add(longAttr, -90L).build()
     idx = partitioner3.getBucketIndex(tuple)
-    assert(idx.next() == 1)
+    assert(idx.toList == List(1))
+  }
+
+  "RangeBasedShuffleSpec" should "refuse a range attribute it cannot widen to a Long" in {
+    // Only LONG / INTEGER / DOUBLE reach the bucket arithmetic. Anything else has to fail loudly:
+    // `fieldVal` starts at -1, so a silently skipped type would route every tuple of that column
+    // to bucket 0 (below rangeMin) instead of spreading it, and the sort a RangePartition exists
+    // to enable would be wrong rather than absent.
+    val stringAttr: Attribute = new Attribute("Attr4", AttributeType.STRING)
+    // Two range attributes, the unsupported one FIRST. Only `rangeAttributeNames.head` is
+    // consulted, so a partitioner that reached for any other name would find the INTEGER column
+    // and bucket the tuple instead of refusing it -- which for the one production declarer
+    // (SortPartitionsOpDesc) means routing by an unintended column rather than failing.
+    val stringSchema: Schema = Schema().add(stringAttr).add(attr)
+    val partitioning4: RangeBasedShufflePartitioning =
+      RangeBasedShufflePartitioning(
+        400,
+        List(
+          ChannelIdentity(identifier, fakeID1, isControl = false),
+          ChannelIdentity(identifier, fakeID2, isControl = false)
+        ),
+        Seq("Attr4", "Attr1"),
+        -400,
+        600
+      )
+    val partitioner4: RangeBasedShufflePartitioner = RangeBasedShufflePartitioner(partitioning4)
+    val tuple = Tuple.builder(stringSchema).add(stringAttr, "100").add(attr, 5).build()
+
+    val failure = intercept[RuntimeException](partitioner4.getBucketIndex(tuple))
+
+    // The message names the offending *type*, not the attribute: "Attr4" would not tell the user
+    // what about the column is unsupported.
+    assert(failure.getMessage == "unsupported attribute type: string")
+  }
+
+  "RangeBasedShuffleSpec" should "collapse a receiver its channels name twice" in {

Review Comment:
   Test name has a grammatical error ("collapse a receiver its channels name twice"), which makes failure output harder to read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): cover the end-channel and retry handlers and the range partitioner [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8088:
URL: https://github.com/apache/texera/pull/8088


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): cover the end-channel and retry handlers and the range partitioner [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8088:
URL: https://github.com/apache/texera/pull/8088#issuecomment-5460074361

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8088?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 93.54%. Comparing base ([`604f109`](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`10b74b0`](https://app.codecov.io/gh/apache/texera/commit/10b74b0a9bdb5721c978327d0622084722732b34?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :white_check_mark: All tests successful. No failed tests found.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #8088      +/-   ##
   ============================================
   + Coverage     93.52%   93.54%   +0.02%     
   - Complexity     4727     4732       +5     
   ============================================
     Files          1195     1195              
     Lines         48492    48492              
     Branches       5379     5379              
   ============================================
   + Hits          45352    45364      +12     
   + Misses         1693     1684       -9     
   + Partials       1447     1444       -3     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.67% <ø> (+0.06%)` | :arrow_up: | |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `95.86% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.54% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [604f109](https://app.codecov.io/gh/apache/texera/commit/604f10967b368a5a34ae41649e5ecc915f2c9a5c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8088?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): cover the end-channel and retry handlers and the range partitioner [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8088:
URL: https://github.com/apache/texera/pull/8088#issuecomment-5460041534

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 2 better · 🔴 5 worse · ⚪ 8 noise (<±5%) · 0 without baseline
   
   > Compared against main `604f109` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33231123359)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 500 | 0.305 | 19,890/24,930/24,930 us | 🔴 -7.6% / 🔴 +78.2% |
   | 🔴 | bs=100 sw=10 sl=64 | 1,184 | 0.723 | 83,131/106,628/106,628 us | 🔴 +5.3% / 🔴 +12.2% |
   | ⚪ | bs=1000 sw=10 sl=64 | 1,409 | 0.86 | 700,781/843,274/843,274 us | ⚪ within ±5% / 🟢 -19.8% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `604f109` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 500 tuples/sec | 541 tuples/sec | 894.27 tuples/sec | -7.6% | -44.1% |
   | bs=10 sw=10 sl=64 | MB/s | 0.305 MB/s | 0.33 MB/s | 0.546 MB/s | -7.6% | -44.1% |
   | bs=10 sw=10 sl=64 | p50 | 19,890 us | 18,718 us | 11,164 us | +6.3% | +78.2% |
   | bs=10 sw=10 sl=64 | p95 | 24,930 us | 26,538 us | 14,219 us | -6.1% | +75.3% |
   | bs=10 sw=10 sl=64 | p99 | 24,930 us | 26,538 us | 16,863 us | -6.1% | +47.8% |
   | bs=100 sw=10 sl=64 | throughput | 1,184 tuples/sec | 1,228 tuples/sec | 1,158 tuples/sec | -3.6% | +2.2% |
   | bs=100 sw=10 sl=64 | MB/s | 0.723 MB/s | 0.75 MB/s | 0.707 MB/s | -3.6% | +2.3% |
   | bs=100 sw=10 sl=64 | p50 | 83,131 us | 80,137 us | 88,711 us | +3.7% | -6.3% |
   | bs=100 sw=10 sl=64 | p95 | 106,628 us | 101,286 us | 95,062 us | +5.3% | +12.2% |
   | bs=100 sw=10 sl=64 | p99 | 106,628 us | 101,286 us | 102,275 us | +5.3% | +4.3% |
   | bs=1000 sw=10 sl=64 | throughput | 1,409 tuples/sec | 1,412 tuples/sec | 1,188 tuples/sec | -0.2% | +18.6% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.86 MB/s | 0.862 MB/s | 0.725 MB/s | -0.2% | +18.6% |
   | bs=1000 sw=10 sl=64 | p50 | 700,781 us | 697,612 us | 874,204 us | +0.5% | -19.8% |
   | bs=1000 sw=10 sl=64 | p95 | 843,274 us | 816,977 us | 916,845 us | +3.2% | -8.0% |
   | bs=1000 sw=10 sl=64 | p99 | 843,274 us | 816,977 us | 947,186 us | +3.2% | -11.0% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,399.90,200,128000,500,0.305,19889.74,24929.86,24929.86
   1,100,10,64,20,1689.54,2000,1280000,1184,0.723,83131.34,106627.58,106627.58
   2,1000,10,64,20,14192.68,20000,12800000,1409,0.860,700781.42,843274.26,843274.26
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org