You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/24 08:57:49 UTC

[GitHub] [shardingsphere] lanchengx opened a new pull request #13773: [DistSQL] Support `parse sql` statement.

lanchengx opened a new pull request #13773:
URL: https://github.com/apache/shardingsphere/pull/13773


   
   ![image](https://user-images.githubusercontent.com/52209337/143205900-e41ed1ea-ee8c-44b7-9b76-e9a9e18e5159.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] RaigorJiang merged pull request #13773: [DistSQL] Support `parse sql` statement.

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #13773:
URL: https://github.com/apache/shardingsphere/pull/13773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #13773: [DistSQL] Support `parse sql` statement.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #13773:
URL: https://github.com/apache/shardingsphere/pull/13773#discussion_r756041865



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/advanced/AdvancedDistSQLBackendHandlerFactory.java
##########
@@ -38,12 +40,15 @@
      * 
      * @param sqlStatement advanced dist sql statement
      * @param backendConnection backend connection
+     * @param databaseType database type

Review comment:
       Order problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #13773: [DistSQL] Support `parse sql` statement.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #13773:
URL: https://github.com/apache/shardingsphere/pull/13773#discussion_r756041346



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/RALBackendHandlerFactory.java
##########
@@ -44,10 +45,11 @@
      *
      * @param sqlStatement RAL statement
      * @param backendConnection backend connection
+     * @param databaseType database type

Review comment:
       The order should match the actual params.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] lanchengx commented on pull request #13773: [DistSQL] Support `parse sql` statement.

Posted by GitBox <gi...@apache.org>.
lanchengx commented on pull request #13773:
URL: https://github.com/apache/shardingsphere/pull/13773#issuecomment-977669348


   @RaigorJiang could you have a review ? 😀


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org