You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:51 UTC

Re: Review Request 50495: Added PIDGroup module struct.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50495/#review167457
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 3:38 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50495/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 3:38 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added struct module<process::PIDGroup> in module/pid_group.hpp.
> This is necessary for instantiating a PIDGroup via module manager.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/pid_group.hpp PRE-CREATION 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/module/manager.cpp 18ee65796dd5744d36a645e7ca1f5ab0fbce98a5 
> 
> 
> Diff: https://reviews.apache.org/r/50495/diff/5/
> 
> 
> Testing
> -------
> 
> see end of review chain
> 
> 
> Thanks,
> 
> Jay Guo
> 
>