You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/16 06:55:45 UTC
[GitHub] [rocketmq-mqtt] YxAc opened a new pull request, #67: [ISSUE #22] codeCov of protocol.mqtt and protocol.rpc
YxAc opened a new pull request, #67:
URL: https://github.com/apache/rocketmq-mqtt/pull/67
part of enhancing #22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #67: [ISSUE #22] codeCov of protocol.mqtt and protocol.rpc
Posted by GitBox <gi...@apache.org>.
YxAc commented on code in PR #67:
URL: https://github.com/apache/rocketmq-mqtt/pull/67#discussion_r851597148
##########
mqtt-cs/src/test/java/org/apache/rocketmq/mqtt/cs/test/TestConnectHandler.java:
##########
@@ -1,66 +0,0 @@
-/*
Review Comment:
refer to #45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing merged pull request #67: [ISSUE #22] codeCov of protocol.mqtt and protocol.rpc
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #67:
URL: https://github.com/apache/rocketmq-mqtt/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #67: [ISSUE #22] codeCov of protocol.mqtt and protocol.rpc
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #67:
URL: https://github.com/apache/rocketmq-mqtt/pull/67#issuecomment-1100590243
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#67](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8df583b) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/1393642c2397a72077892771883be9d5750611e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1393642) will **increase** coverage by `2.63%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 26.91% 29.55% +2.63%
==========================================
Files 97 97
Lines 4187 4186 -1
Branches 660 660
==========================================
+ Hits 1127 1237 +110
+ Misses 2832 2711 -121
- Partials 228 238 +10
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mq/mqtt/cs/protocol/mqtt/MqttPacketDispatcher.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L01xdHRQYWNrZXREaXNwYXRjaGVyLmphdmE=) | `37.87% <ø> (+37.87%)` | :arrow_up: |
| [...cs/protocol/mqtt/handler/MqttSubscribeHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFN1YnNjcmliZUhhbmRsZXIuamF2YQ==) | `85.41% <ø> (+85.41%)` | :arrow_up: |
| [.../protocol/mqtt/handler/MqttUnSubscribeHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFVuU3Vic2NyaWJlSGFuZGxlci5qYXZh) | `81.48% <ø> (+81.48%)` | :arrow_up: |
| [...cketmq/mqtt/cs/channel/ChannelDecodeException.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9jaGFubmVsL0NoYW5uZWxEZWNvZGVFeGNlcHRpb24uamF2YQ==) | `22.22% <0.00%> (+22.22%)` | :arrow_up: |
| [...etmq/mqtt/cs/protocol/rpc/RpcPacketDispatcher.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9ycGMvUnBjUGFja2V0RGlzcGF0Y2hlci5qYXZh) | `86.95% <0.00%> (+86.95%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1393642...8df583b](https://codecov.io/gh/apache/rocketmq-mqtt/pull/67?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org