You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/06 15:57:36 UTC

[GitHub] [kafka] emilnkrastev commented on a diff in pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

emilnkrastev commented on code in PR #11818:
URL: https://github.com/apache/kafka/pull/11818#discussion_r1063558786


##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java:
##########
@@ -81,15 +88,25 @@ public void testOffsetSync() {
         MirrorSourceTask.PartitionState partitionState = new MirrorSourceTask.PartitionState(50);
 
         assertTrue(partitionState.update(0, 100), "always emit offset sync on first update");
+        partitionState.reset();

Review Comment:
   Increase the test coverage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org