You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (Jira)" <ji...@apache.org> on 2022/07/26 20:14:00 UTC
[jira] [Commented] (SPARK-39881) Python Lint does not actually check for `black` formatter
[ https://issues.apache.org/jira/browse/SPARK-39881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571600#comment-17571600 ]
Apache Spark commented on SPARK-39881:
--------------------------------------
User 'grundprinzip' has created a pull request for this issue:
https://github.com/apache/spark/pull/37305
> Python Lint does not actually check for `black` formatter
> ---------------------------------------------------------
>
> Key: SPARK-39881
> URL: https://issues.apache.org/jira/browse/SPARK-39881
> Project: Spark
> Issue Type: Improvement
> Components: Build, PySpark
> Affects Versions: 3.3.0
> Reporter: Martin Grund
> Priority: Major
>
> In our current `dev/lint-python` script we execute the following check: {{}}
>
> {code:java}
> $BLACK_BUILD 2> /dev/null
> if [ $? -ne 0 ]; then
> # ...
> fi{code}
> However, even if black is installed simply invoking it will actually return a non-zero exit code because no src files have been specified. To correctly check for the existence of `black` we need a different check.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org