You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Claudenw (via GitHub)" <gi...@apache.org> on 2024/03/02 19:01:20 UTC
[PR] [CLI-327] Fix for expected textual date values. [commons-cli]
Claudenw opened a new pull request, #244:
URL: https://github.com/apache/commons-cli/pull/244
Fixes for CLI-327
In some cases the time zone for the expected date string is different than the hard coded version. This change creates the expected value from a known simple date format of the Date argument so that the expected value always matches the produced time zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CLI-327] Fix for expected textual date values. [commons-cli]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #244:
URL: https://github.com/apache/commons-cli/pull/244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CLI-327] Fix for expected textual date values. [commons-cli]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on PR #244:
URL: https://github.com/apache/commons-cli/pull/244#issuecomment-1975087319
> Hi @Claudenw Thank you for your PR. The explanation in the description of this PR needs to be a comment in the test to warn people NOT to write the old style of test again.
Added comments to the 3 tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CLI-327] Fix for expected textual date values. [commons-cli]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #244:
URL: https://github.com/apache/commons-cli/pull/244#issuecomment-1974879733
## [Codecov](https://app.codecov.io/gh/apache/commons-cli/pull/244?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 92.09%. Comparing base [(`9f6b23b`)](https://app.codecov.io/gh/apache/commons-cli/commit/9f6b23b04d88fef2eaa67607753f3fc82375c52e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5273865`)](https://app.codecov.io/gh/apache/commons-cli/pull/244?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 40 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #244 +/- ##
============================================
+ Coverage 91.90% 92.09% +0.19%
- Complexity 575 592 +17
============================================
Files 22 22
Lines 1247 1265 +18
Branches 210 211 +1
============================================
+ Hits 1146 1165 +19
+ Misses 63 60 -3
- Partials 38 40 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-cli/pull/244?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CLI-327] Fix for expected textual date values. [commons-cli]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #244:
URL: https://github.com/apache/commons-cli/pull/244#issuecomment-1974886621
Hi @Claudenw
Thank you for your PR.
The explanation in the description of this PR needs to be a comment in the test to warn people NOT to write the old style of test again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CLI-327] Fix for expected textual date values. [commons-cli]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #244:
URL: https://github.com/apache/commons-cli/pull/244#issuecomment-1975205539
TY @Claudenw
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org