You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Flink Jira Bot (Jira)" <ji...@apache.org> on 2022/03/06 10:39:00 UTC

[jira] [Updated] (FLINK-24247) Uniformly limit the value of ABS(offset) in all window

     [ https://issues.apache.org/jira/browse/FLINK-24247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flink Jira Bot updated FLINK-24247:
-----------------------------------
    Labels: pull-request-available stale-major  (was: pull-request-available)

I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see this issues has been marked as Major but is unassigned and neither itself nor its Sub-Tasks have been updated for 60 days. I have gone ahead and added a "stale-major" to the issue". If this ticket is a Major, please either assign yourself or give an update. Afterwards, please remove the label or in 7 days the issue will be deprioritized.


> Uniformly limit the value of ABS(offset)  in all window
> -------------------------------------------------------
>
>                 Key: FLINK-24247
>                 URL: https://issues.apache.org/jira/browse/FLINK-24247
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Runtime
>            Reporter: liwei li
>            Priority: Major
>              Labels: pull-request-available, stale-major
>
> when i test Window TVF offset([FLINK-23747|https://issues.apache.org/jira/browse/FLINK-23747?focusedCommentId=17410923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17410923]), i found that TUMBLE WINDOW limit the value of ABS (offset) to be less than window size, but HOP\CUMULATE Windows does not have this limit. Do we  uniformly add this restriction to all of them? If add limit is appropriate, give me the ticket and I'll create a pr.
>  
>  
> {code:java}
>              checkArgument(
>                     Math.abs(offset) < size,
>                     String.format(
>                             "Tumbling Window parameters must satisfy abs(offset) < size, bot got size %dms and offset %dms.",
>                             size, offset));
> {code}
>  
> [https://github.com/apache/flink/blob/c13b749782d0d72647ec6d73ce1eb22b57f2be7d/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java#L154]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)