You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jp...@apache.org on 2018/08/13 17:37:23 UTC

lucene-solr:master: LUCENE-8449: Code Optimizations in FieldTermStack

Repository: lucene-solr
Updated Branches:
  refs/heads/master be4a33938 -> bb5816357


LUCENE-8449: Code Optimizations in FieldTermStack

Signed-off-by: Adrien Grand <jp...@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/bb581635
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/bb581635
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/bb581635

Branch: refs/heads/master
Commit: bb5816357810094abf05d34a2b9325182f36fcd1
Parents: be4a339
Author: danmuzi <kn...@gmail.com>
Authored: Tue Aug 14 01:36:01 2018 +0900
Committer: Adrien Grand <jp...@gmail.com>
Committed: Mon Aug 13 19:36:39 2018 +0200

----------------------------------------------------------------------
 .../lucene/search/vectorhighlight/FieldTermStack.java    | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/bb581635/lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/FieldTermStack.java
----------------------------------------------------------------------
diff --git a/lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/FieldTermStack.java b/lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/FieldTermStack.java
index f67ba80..b1700c8 100644
--- a/lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/FieldTermStack.java
+++ b/lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/FieldTermStack.java
@@ -196,7 +196,7 @@ public class FieldTermStack {
     // this is a circular list, so with no syns, just points to itself
     private TermInfo next;
 
-    public TermInfo( String text, int startOffset, int endOffset, int position, float weight ){
+    TermInfo(String text, int startOffset, int endOffset, int position, float weight){
       this.text = text;
       this.startOffset = startOffset;
       this.endOffset = endOffset;
@@ -219,9 +219,7 @@ public class FieldTermStack {
     
     @Override
     public String toString(){
-      StringBuilder sb = new StringBuilder();
-      sb.append( text ).append( '(' ).append(startOffset).append( ',' ).append( endOffset ).append( ',' ).append( position ).append( ')' );
-      return sb.toString();
+      return text + '(' + startOffset + ',' + endOffset + ',' + position + ')';
     }
 
     @Override
@@ -248,10 +246,7 @@ public class FieldTermStack {
         return false;
       }
       TermInfo other = (TermInfo) obj;
-      if (position != other.position) {
-        return false;
-      }
-      return true;
+      return position == other.position;
     }
   }
 }