[GitHub] [hbase] wchevreuil commented on a change in pull request #494: HBASE-22380 break circle replication when doing bulkload

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #494: HBASE-22380 break circle replication when doing bulkload
URL: https://github.com/apache/hbase/pull/494#discussion_r314988015
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
 ##########
 @@ -243,14 +251,20 @@ public void replicateEntries(List<WALEntry> entries, final CellScanner cells,
         LOG.debug("Finished replicating mutations.");
       }
 
-      if (bulkLoadHFileMap != null && !bulkLoadHFileMap.isEmpty()) {
-        LOG.debug("Started replicating bulk loaded data.");
-        HFileReplicator hFileReplicator =
-            new HFileReplicator(this.provider.getConf(this.conf, replicationClusterId),
+      if(bulkLoadsPerClusters != null) {
+        for (String clusterId : bulkLoadsPerClusters.keySet()) {
 
 Review comment:
   On the reported findbugs issue: We do need to iterate over the keySet, as we do need the clusterId further to forward it to HFileReplicator call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services