You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Geoff Hayman (JIRA)" <ji...@apache.org> on 2012/09/18 19:24:07 UTC
[jira] [Created] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Geoff Hayman created WICKET-4770:
------------------------------------
Summary: Wicket 6: modal windows in Safari are always in drag or resize mode
Key: WICKET-4770
URL: https://issues.apache.org/jira/browse/WICKET-4770
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.0.0
Environment: Safari - all OS
Reporter: Geoff Hayman
In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Geoff Hayman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457970#comment-13457970 ]
Geoff Hayman commented on WICKET-4770:
--------------------------------------
The modal dialog tries to set event.ignore=true if the browser is Safari. This Wicket event data structure used to be passed through to Wicket.Drag.mouseDownHandler as the argument e. However, in the switch over to jQuery events the argument (e) passed to mouseDownHandler is no longer Wicket "event". It is now jQuery event data.
There is a test in mouseDownHandler to check for the existence of e.ignore. As this is now jQuery data, it _never_ exists, so Safari is never recognized.
I changed this test to check event.ignore and it appears to work correctly.
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Geoff Hayman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Geoff Hayman updated WICKET-4770:
---------------------------------
Attachment: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
Patch file to resolve issue
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462469#comment-13462469 ]
Emond Papegaaij commented on WICKET-4770:
-----------------------------------------
Ok, I didn't expect wicket-ajax-jquery.js to contain hacks to just get modal windows working. I tried to find when this code was added, but it goes beyond recorded history of the ModalWindow. The first commit with this ignore flag is from the initial addition of modal window, back in august 2006. I hardly doubt that this hack is still relevant. Unfortunately, I don't have Safari to test it in, so I'll ask Martijn to test if this hack can be removed.
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Fix For: 6.1.0
>
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4770:
------------------------------------
Fix Version/s: 6.1.0
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Fix For: 6.1.0
>
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij updated WICKET-4770:
------------------------------------
Attachment: WICKET-4770-remove-hack.diff
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Fix For: 6.1.0
>
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch, WICKET-4770-remove-hack.diff
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Geoff Hayman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462095#comment-13462095 ]
Geoff Hayman commented on WICKET-4770:
--------------------------------------
event.ignore is set on line 1200 of modal.js (Wicket 6.0). This is specifically NOT the jQuery event object which is why the later test was failing.
When I changed the later test to test against event.ignore (non-jQuery object) rather than e.ignore (jQuery object) the function worked as expected.
Whether this is 100% the correct change I will leave up to those more knowledgeable in the Wicket code, but I can say that it worked for us with no other apparent side effects.
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Fix For: 6.1.0
>
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-4770) Wicket 6: modal windows in
Safari are always in drag or resize mode
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462469#comment-13462469 ]
Emond Papegaaij edited comment on WICKET-4770 at 9/25/12 5:07 PM:
------------------------------------------------------------------
Ok, I didn't expect wicket-ajax-jquery.js to contain hacks to just get modal windows working. I tried to find when this code was added, but it goes beyond recorded history of the ModalWindow. The first commit with this ignore flag is from the initial addition of modal window, back in august 2006. I highly doubt that this hack is still relevant. Unfortunately, I don't have Safari to test it in, so I'll ask Martijn to test if this hack can be removed.
was (Author: papegaaij):
Ok, I didn't expect wicket-ajax-jquery.js to contain hacks to just get modal windows working. I tried to find when this code was added, but it goes beyond recorded history of the ModalWindow. The first commit with this ignore flag is from the initial addition of modal window, back in august 2006. I hardly doubt that this hack is still relevant. Unfortunately, I don't have Safari to test it in, so I'll ask Martijn to test if this hack can be removed.
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Fix For: 6.1.0
>
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch, WICKET-4770-remove-hack.diff
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij resolved WICKET-4770.
-------------------------------------
Resolution: Fixed
Assignee: Emond Papegaaij
A coworker tested my proposal on Safari, and the hack is no longer needed. I've removed the hack on both ends of the code.
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Assignee: Emond Papegaaij
> Fix For: 6.1.0
>
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch, WICKET-4770-remove-hack.diff
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461339#comment-13461339 ]
Emond Papegaaij commented on WICKET-4770:
-----------------------------------------
Although I don't know the code that well, I don't think the patch is correct. I cannot find any code that sets the 'ignore' flag on the jQuery event. Therefore is presume that with this patch, the if-condition will always be true. If that seems to work correctly, perhaps the solution is to remove the if entirely?
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Fix For: 6.1.0
>
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira