You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/09/03 14:23:35 UTC

[GitHub] wu-sheng edited a comment on issue #1585: Increase the ability to reset apps and instances

wu-sheng edited a comment on issue #1585: Increase the ability to reset apps and instances
URL: https://github.com/apache/incubator-skywalking/issues/1585#issuecomment-418129868
 
 
   > Loss of metadata due to misoperation is not a defect in the skywalking system. If the reset causes the id of the data before and after the agent to be inconsistent, an exception needs to be thrown to inform the user that his operation has caused the metadata to be lost. Therefore, the method of manually triggering the reset is adopted.
   
   - Automatic triggering
   How do you know about **inconsistent**? For the metadata missing or partial missing, there is no way the backend could know. Could you info me more about `inconsistent check` mechanism? The only thing in my mind, which doesn't break performance, is when you can't get the name of service/endpoint-ip from cache, you know something is wrong. But this is really part of fact called `inconsistent check`. 
   
   For me, this could be dangerous to tell people, SkyWalking has `inconsistent check`, because this mechanism can't guarantee **no exception = data is right**.
   
   > If you choose to manually send commands in the management interface, you need to know which agent registration data is lost. Obviously, the metadata has been lost and there is no way to get it. Similarly, the collector side cannot be manually implemented.
   
   If you can't do this manually, I doubt the meaning of this check. This is not a pattern recognition, which AI may do better than human, otherwise, this is a fault check, I am pretty sure, human check is the most reliable thing and the final defence.
   
   > 1.2.2 How to identify the agent that needs to be re-registered
   Uniquely determine the instance location by adding the instance_code attribute to the agent.conf configuration file.
   
   How is this could identify the `needs to` thing? Could you explain more? `Uniquely determine the instance location` this is an ID of service instance, yes. Then?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services