You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 07:40:06 UTC
[GitHub] [flink] zentol opened a new pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
zentol opened a new pull request #12213:
URL: https://github.com/apache/flink/pull/12213
This reverts commit 865cc4c7a39f7aa610a02cc4a0f41424edcd6279.
The addition of quotes means that the log settings are passed as a single argument, rendering it ineffective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630688114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74c9e440c684f255faa2075c12e4438590631dae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
}, {
"hash" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"triggerType" : "PUSH"
}, {
"hash" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1824",
"triggerID" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74c9e440c684f255faa2075c12e4438590631dae Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699)
* f5de677e8b50e1df6c5207efe4bb11367d174207 UNKNOWN
* bcc350d071faa0135f88974bad9e81eca02352e9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1824)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630638359
Sounds good @zentol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74c9e440c684f255faa2075c12e4438590631dae Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #12213:
URL: https://github.com/apache/flink/pull/12213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
}, {
"hash" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"triggerType" : "PUSH"
}, {
"hash" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1824",
"triggerID" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"triggerType" : "PUSH"
}, {
"hash" : "a4a2bc16e03ff3ad12a21f218581f16971804d80",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1839",
"triggerID" : "a4a2bc16e03ff3ad12a21f218581f16971804d80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5de677e8b50e1df6c5207efe4bb11367d174207 UNKNOWN
* bcc350d071faa0135f88974bad9e81eca02352e9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1824)
* a4a2bc16e03ff3ad12a21f218581f16971804d80 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
}, {
"hash" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74c9e440c684f255faa2075c12e4438590631dae Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699)
* f5de677e8b50e1df6c5207efe4bb11367d174207 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630006554
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 74c9e440c684f255faa2075c12e4438590631dae (Mon May 18 07:46:53 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630227693
Probably not. I'll try adding some escaped quotes to the individual log settings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
}, {
"hash" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"triggerType" : "PUSH"
}, {
"hash" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1824",
"triggerID" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"triggerType" : "PUSH"
}, {
"hash" : "a4a2bc16e03ff3ad12a21f218581f16971804d80",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a4a2bc16e03ff3ad12a21f218581f16971804d80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5de677e8b50e1df6c5207efe4bb11367d174207 UNKNOWN
* bcc350d071faa0135f88974bad9e81eca02352e9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1824)
* a4a2bc16e03ff3ad12a21f218581f16971804d80 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
}, {
"hash" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"triggerType" : "PUSH"
}, {
"hash" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74c9e440c684f255faa2075c12e4438590631dae Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699)
* f5de677e8b50e1df6c5207efe4bb11367d174207 UNKNOWN
* bcc350d071faa0135f88974bad9e81eca02352e9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
}, {
"hash" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5de677e8b50e1df6c5207efe4bb11367d174207",
"triggerType" : "PUSH"
}, {
"hash" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1824",
"triggerID" : "bcc350d071faa0135f88974bad9e81eca02352e9",
"triggerType" : "PUSH"
}, {
"hash" : "a4a2bc16e03ff3ad12a21f218581f16971804d80",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1839",
"triggerID" : "a4a2bc16e03ff3ad12a21f218581f16971804d80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5de677e8b50e1df6c5207efe4bb11367d174207 UNKNOWN
* a4a2bc16e03ff3ad12a21f218581f16971804d80 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630019128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74c9e440c684f255faa2075c12e4438590631dae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699",
"triggerID" : "74c9e440c684f255faa2075c12e4438590631dae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74c9e440c684f255faa2075c12e4438590631dae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1699)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630688114
@tillrohrmann Escaped quotes don't; but I found another solution using arrays in the [BashFAQ|http://mywiki.wooledge.org/BashFAQ/050].
This seems to work.
... I also found this in flink-daemon.sh; could've saved some time there...
There were also other cases where we did not properly handled spaces (FLINK-17809); I have included a fix for this in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630006554
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c30d3ecee9363a40f6c49d10388161f47e512801 (Fri Oct 16 10:51:03 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630688114
@tillrohrmann Escaped quotes don't; but I found another solution using arrays in the [BashFAQ|http://mywiki.wooledge.org/BashFAQ/050].
This seems to work. Well, I just saw the same solution in `flink-daemon.sh`; my god we should deduplicate this stuff finally.
There were also other cases where we did not properly handled spaces (FLINK-17809); I have included a fix for this in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #12213: Revert "[FLINK-13827][script] shell variable should be escaped"
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #12213:
URL: https://github.com/apache/flink/pull/12213#issuecomment-630688114
@tillrohrmann Escaped quotes don't; but I found another solution using arrays in the [BashFAQ](http://mywiki.wooledge.org/BashFAQ/050).
This seems to work.
... I also found this in flink-daemon.sh; could've saved some time there...
There were also other cases where we did not properly handled spaces (FLINK-17809); I have included a fix for this in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org