You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/04 08:32:04 UTC
[GitHub] [pulsar] eolivelli commented on a change in pull request #7605: Support partitioned topic lookup
eolivelli commented on a change in pull request #7605:
URL: https://github.com/apache/pulsar/pull/7605#discussion_r499220083
##########
File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java
##########
@@ -41,6 +42,14 @@
*/
CompletableFuture<String> lookupTopicAsync(String topic);
+ /**
+ * Lookup a partitioned topic.
+ *
+ * @param topic
+ * @return the broker URL that serves the topic
+ */
Review comment:
This method should return a CompletableFuture as the method above
##########
File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java
##########
@@ -41,6 +42,14 @@
*/
CompletableFuture<String> lookupTopicAsync(String topic);
+ /**
+ * Lookup a partitioned topic.
+ *
+ * @param topic
+ * @return the broker URL that serves the topic
+ */
+ Map<String, String> lookupPartitionedTopic(String topic) throws PulsarAdminException;
Review comment:
This method should return a CompletableFuture as the method above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org