You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@flagon.apache.org by "EandrewJones (via GitHub)" <gi...@apache.org> on 2023/11/06 18:20:19 UTC
[PR] [WIP] OpenTelemetry Web Request Tracing (flagon-useralejs)
EandrewJones opened a new pull request, #388:
URL: https://github.com/apache/flagon-useralejs/pull/388
Status
---------
- install and build in progress
- I've added the nodePolyfills plugin for rollup but introduced new errors.
Instructions
------------------
- on fetch, run `npm install`
- run `npm run pretest` to see build warnings/errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@flagon.apache.org
For additional commands, e-mail: pr-help@flagon.apache.org
Re: [PR] [WIP] OpenTelemetry Web Request Tracing (flagon-useralejs)
Posted by "EandrewJones (via GitHub)" <gi...@apache.org>.
EandrewJones commented on PR #388:
URL: https://github.com/apache/flagon-useralejs/pull/388#issuecomment-1796167684
Apologies for breach of convention.
Can do. I believe my VS code is auto-formatting on save so I'll have to
parse that out.
Best
Evan Jones
Website: www.ea-jones.com
On Mon, Nov 6, 2023 at 1:50 PM Jason Young ***@***.***> wrote:
> I'm going to dig into this, but first here's some notes on working in this
> repo:
>
> - Include the build in your branch.
> - Make PR's to test.
> - For QOL, can you separate the formatting changes and the code
> changes into different commits?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/flagon-useralejs/pull/388#issuecomment-1795924928>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJ2T6AIGQ7FNFZNS6KTJ5QDYDEWPZAVCNFSM6AAAAAA676C7CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVHEZDIOJSHA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@flagon.apache.org
For additional commands, e-mail: notifications-help@flagon.apache.org
Re: [PR] [WIP] OpenTelemetry Web Request Tracing (flagon-useralejs)
Posted by "Jyyjy (via GitHub)" <gi...@apache.org>.
Jyyjy commented on PR #388:
URL: https://github.com/apache/flagon-useralejs/pull/388#issuecomment-1795924928
I'm going to dig into this, but first here's some notes on working in this repo:
- Include the build in your branch.
- Make PR's to test.
- For QOL, can you separate the formatting changes and the code changes into different commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@flagon.apache.org
For additional commands, e-mail: notifications-help@flagon.apache.org
Re: [PR] [WIP] OpenTelemetry Web Request Tracing (flagon-useralejs)
Posted by "Jyyjy (via GitHub)" <gi...@apache.org>.
Jyyjy commented on PR #388:
URL: https://github.com/apache/flagon-useralejs/pull/388#issuecomment-1837529819
After working on this with Evan, we couldn't get a successful build. The opentelemetry package requires perf hooks, but we couldn't find any polyfill in the rollup ecosystem that supports it. We concluded that adding otel would require migrating to a different bundler.
We instead updated an example webpack site that injects otel info into userale logs. Check it out here:
https://github.com/UMD-ARLIS/incubator-flagon-useralejs/tree/OTintegration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@flagon.apache.org
For additional commands, e-mail: notifications-help@flagon.apache.org
Re: [PR] [WIP] OpenTelemetry Web Request Tracing (flagon-useralejs)
Posted by "UMD-ARLIS (via GitHub)" <gi...@apache.org>.
UMD-ARLIS closed pull request #388: [WIP] OpenTelemetry Web Request Tracing
URL: https://github.com/apache/flagon-useralejs/pull/388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@flagon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@flagon.apache.org
For additional commands, e-mail: pr-help@flagon.apache.org