You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/02/27 10:13:29 UTC
Review Request 31531: LENS-361 Hive driver not getting database jars
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31531/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-361
https://issues.apache.org/jira/browse/LENS-361
Repository: lens
Description
-------
1. Using add jars when sending DB jars to hive driver, to reduce number of queries run to add resources.
2. Jar order specified in jar_order file in the db jar directory. One jar per line. Same order is passed on to Hive driver.
3. Setting session id in prepared and explain query contexts.
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1217e38d38d02ebc49e2a98d38638e9f4bd10633
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java df2d746169629ecd71c91eef1b639afe8e713a1f
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java d5f38727c594ca34e21f2e19d280854f64c21ed5
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java c6cd18010ae5bff195ca6ce52f0173a52b94a349
Diff: https://reviews.apache.org/r/31531/diff/
Testing
-------
1. Verified jars picked up by DatabaseResourceService in the order specified in jar_order file
2. Verified jars added to hive session in correct order
Awaiting Test output -
Thanks,
Jaideep dhok
Re: Review Request 31531: LENS-361 Hive driver not getting database
jars
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31531/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 10:08 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Checkstyle changes.
Bugs: LENS-361
https://issues.apache.org/jira/browse/LENS-361
Repository: lens
Description
-------
1. Using add jars when sending DB jars to hive driver, to reduce number of queries run to add resources.
2. Jar order specified in jar_order file in the db jar directory. One jar per line. Same order is passed on to Hive driver.
3. Setting session id in prepared and explain query contexts.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1217e38d38d02ebc49e2a98d38638e9f4bd10633
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java df2d746169629ecd71c91eef1b639afe8e713a1f
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java d5f38727c594ca34e21f2e19d280854f64c21ed5
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java c6cd18010ae5bff195ca6ce52f0173a52b94a349
Diff: https://reviews.apache.org/r/31531/diff/
Testing
-------
1. Verified jars picked up by DatabaseResourceService in the order specified in jar_order file
2. Verified jars added to hive session in correct order
Test output -
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.103s]
[INFO] Lens .............................................. SUCCESS [1.842s]
[INFO] Lens API .......................................... SUCCESS [5.608s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.589s]
[INFO] Lens Cube ......................................... SUCCESS [7:03.320s]
[INFO] Lens DB storage ................................... SUCCESS [10.786s]
[INFO] Lens Query Library ................................ SUCCESS [4.534s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:32.656s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.051s]
[INFO] Lens Server ....................................... SUCCESS [5:11.149s]
[INFO] Lens client ....................................... SUCCESS [20.450s]
[INFO] Lens CLI .......................................... SUCCESS [1:48.158s]
[INFO] Lens Examples ..................................... SUCCESS [0.900s]
[INFO] Lens Distribution ................................. SUCCESS [8.801s]
[INFO] Lens ML Lib ....................................... SUCCESS [47.744s]
[INFO] Lens Regression ................................... SUCCESS [0.447s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:50.131s
[INFO] Finished at: Fri Feb 27 09:51:44 UTC 2015
[INFO] Final Memory: 108M/1339M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 31531: LENS-361 Hive driver not getting database
jars
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31531/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 9:55 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-361
https://issues.apache.org/jira/browse/LENS-361
Repository: lens
Description
-------
1. Using add jars when sending DB jars to hive driver, to reduce number of queries run to add resources.
2. Jar order specified in jar_order file in the db jar directory. One jar per line. Same order is passed on to Hive driver.
3. Setting session id in prepared and explain query contexts.
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1217e38d38d02ebc49e2a98d38638e9f4bd10633
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java df2d746169629ecd71c91eef1b639afe8e713a1f
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java d5f38727c594ca34e21f2e19d280854f64c21ed5
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java c6cd18010ae5bff195ca6ce52f0173a52b94a349
Diff: https://reviews.apache.org/r/31531/diff/
Testing (updated)
-------
1. Verified jars picked up by DatabaseResourceService in the order specified in jar_order file
2. Verified jars added to hive session in correct order
Test output -
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.103s]
[INFO] Lens .............................................. SUCCESS [1.842s]
[INFO] Lens API .......................................... SUCCESS [5.608s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.589s]
[INFO] Lens Cube ......................................... SUCCESS [7:03.320s]
[INFO] Lens DB storage ................................... SUCCESS [10.786s]
[INFO] Lens Query Library ................................ SUCCESS [4.534s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:32.656s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.051s]
[INFO] Lens Server ....................................... SUCCESS [5:11.149s]
[INFO] Lens client ....................................... SUCCESS [20.450s]
[INFO] Lens CLI .......................................... SUCCESS [1:48.158s]
[INFO] Lens Examples ..................................... SUCCESS [0.900s]
[INFO] Lens Distribution ................................. SUCCESS [8.801s]
[INFO] Lens ML Lib ....................................... SUCCESS [47.744s]
[INFO] Lens Regression ................................... SUCCESS [0.447s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:50.131s
[INFO] Finished at: Fri Feb 27 09:51:44 UTC 2015
[INFO] Final Memory: 108M/1339M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 31531: LENS-361 Hive driver not getting database
jars
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31531/#review74466
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java
<https://reviews.apache.org/r/31531/#comment121053>
Its indeed put in reverse order.
```
$ cat lens-server/target/resources//TestDatabaseResourceServicedb1/jar_order
z_TestDatabaseResourceServicedb1.jar
y_TestDatabaseResourceServicedb1.jar
x_TestDatabaseResourceServicedb1.jar
```
Added in reverse order in the array.
- Jaideep dhok
On Feb. 27, 2015, 9:13 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31531/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 9:13 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-361
> https://issues.apache.org/jira/browse/LENS-361
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Using add jars when sending DB jars to hive driver, to reduce number of queries run to add resources.
> 2. Jar order specified in jar_order file in the db jar directory. One jar per line. Same order is passed on to Hive driver.
> 3. Setting session id in prepared and explain query contexts.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1217e38d38d02ebc49e2a98d38638e9f4bd10633
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java df2d746169629ecd71c91eef1b639afe8e713a1f
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java d5f38727c594ca34e21f2e19d280854f64c21ed5
> lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java c6cd18010ae5bff195ca6ce52f0173a52b94a349
>
> Diff: https://reviews.apache.org/r/31531/diff/
>
>
> Testing
> -------
>
> 1. Verified jars picked up by DatabaseResourceService in the order specified in jar_order file
> 2. Verified jars added to hive session in correct order
>
> Awaiting Test output -
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 31531: LENS-361 Hive driver not getting database
jars
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31531/#review74464
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java
<https://reviews.apache.org/r/31531/#comment121052>
Can you put different order than x, y and z? This is alphabatical order also, lets put reverse order for order file to be tested
- Amareshwari Sriramadasu
On Feb. 27, 2015, 9:13 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31531/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 9:13 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-361
> https://issues.apache.org/jira/browse/LENS-361
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Using add jars when sending DB jars to hive driver, to reduce number of queries run to add resources.
> 2. Jar order specified in jar_order file in the db jar directory. One jar per line. Same order is passed on to Hive driver.
> 3. Setting session id in prepared and explain query contexts.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1217e38d38d02ebc49e2a98d38638e9f4bd10633
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java df2d746169629ecd71c91eef1b639afe8e713a1f
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java d5f38727c594ca34e21f2e19d280854f64c21ed5
> lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java c6cd18010ae5bff195ca6ce52f0173a52b94a349
>
> Diff: https://reviews.apache.org/r/31531/diff/
>
>
> Testing
> -------
>
> 1. Verified jars picked up by DatabaseResourceService in the order specified in jar_order file
> 2. Verified jars added to hive session in correct order
>
> Awaiting Test output -
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 31531: LENS-361 Hive driver not getting database
jars
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31531/#review74467
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Feb. 27, 2015, 9:13 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31531/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 9:13 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-361
> https://issues.apache.org/jira/browse/LENS-361
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Using add jars when sending DB jars to hive driver, to reduce number of queries run to add resources.
> 2. Jar order specified in jar_order file in the db jar directory. One jar per line. Same order is passed on to Hive driver.
> 3. Setting session id in prepared and explain query contexts.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1217e38d38d02ebc49e2a98d38638e9f4bd10633
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java df2d746169629ecd71c91eef1b639afe8e713a1f
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java d5f38727c594ca34e21f2e19d280854f64c21ed5
> lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java c6cd18010ae5bff195ca6ce52f0173a52b94a349
>
> Diff: https://reviews.apache.org/r/31531/diff/
>
>
> Testing
> -------
>
> 1. Verified jars picked up by DatabaseResourceService in the order specified in jar_order file
> 2. Verified jars added to hive session in correct order
>
> Awaiting Test output -
>
>
> Thanks,
>
> Jaideep dhok
>
>