You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/06 04:09:41 UTC
[GitHub] [incubator-tvm] liangfu opened a new pull request #4998:
[VTA][Chisel] Change Scala Linter scalafmt => scalastyle
liangfu opened a new pull request #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998
As scalafmt changes the code even with `--test` argument in the latest version, this PR switches scala linter for Chisel VTA from scalafmt to scalastyle.
@tmoreau89 @vegaluisjose Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tmoreau89 commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595869553
Thanks for the diff @liangfu ; this looks great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] liangfu commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
liangfu commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595612183
In addition, I made some final changes in fixing indentation errors, here is a typical example:
```diff
diff --git a/vta/hardware/chisel/src/main/scala/core/Load.scala b/vta/hardware/chisel/src/main/scala/core/Load.scala
index 7c79498bd..50c26bb8e 100644
--- a/vta/hardware/chisel/src/main/scala/core/Load.scala
+++ b/vta/hardware/chisel/src/main/scala/core/Load.scala
@@ -25,12 +25,12 @@ import vta.util.config._
import vta.shell._
/** Load.
- *
- * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
- * This module instantiate the TensorLoad unit which is in charge of
- * loading 1D and 2D tensors to scratchpads, so it can be used by
- * other modules such as Compute.
- */
+ *
+ * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
+ * This module instantiate the TensorLoad unit which is in charge of
+ * loading 1D and 2D tensors to scratchpads, so it can be used by
+ * other modules such as Compute.
+ */
class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
val mp = p(ShellKey).memParams
val io = IO(new Bundle {
@@ -110,11 +110,10 @@ class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
when(dec.io.isSync) {
printf("[Load] start sync\n")
}.elsewhen(dec.io.isInput) {
- printf("[Load] start input\n")
- }
- .elsewhen(dec.io.isWeight) {
- printf("[Load] start weight\n")
- }
+ printf("[Load] start input\n")
+ }.elsewhen(dec.io.isWeight) {
+ printf("[Load] start weight\n")
+ }
}
// done
when(state === sSync) {
```
Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tmoreau89 merged pull request #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] liangfu commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
liangfu commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595594406
vta/apps still need to be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tmoreau89 commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595869914
Looks like CI failed on one of the unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] liangfu commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
liangfu commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-596068024
I think it might related to #4901 , let me trigger the testing pipeline again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tmoreau89 commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-596125703
Thanks @liangfu, @vegaluisjose the PR has been merged!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tmoreau89 commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595596630
Thanks @liangfu ; let us know when it's ready for a merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] liangfu commented on issue #4998: [VTA][Chisel]
Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
liangfu commented on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595597598
@tmoreau89 @vegaluisjose Thanks for the review. I think this is now ready for a merge, and let's wait for the CI testing results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] liangfu removed a comment on issue #4998:
[VTA][Chisel] Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
liangfu removed a comment on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595594406
vta/apps still need to be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] liangfu edited a comment on issue #4998:
[VTA][Chisel] Change Scala Linter scalafmt => scalastyle
Posted by GitBox <gi...@apache.org>.
liangfu edited a comment on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595612183
In addition, based on the suggestions in the linter, I made some final changes in fixing indentation errors, here is a typical example:
```diff
diff --git a/vta/hardware/chisel/src/main/scala/core/Load.scala b/vta/hardware/chisel/src/main/scala/core/Load.scala
index 7c79498bd..50c26bb8e 100644
--- a/vta/hardware/chisel/src/main/scala/core/Load.scala
+++ b/vta/hardware/chisel/src/main/scala/core/Load.scala
@@ -25,12 +25,12 @@ import vta.util.config._
import vta.shell._
/** Load.
- *
- * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
- * This module instantiate the TensorLoad unit which is in charge of
- * loading 1D and 2D tensors to scratchpads, so it can be used by
- * other modules such as Compute.
- */
+ *
+ * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
+ * This module instantiate the TensorLoad unit which is in charge of
+ * loading 1D and 2D tensors to scratchpads, so it can be used by
+ * other modules such as Compute.
+ */
class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
val mp = p(ShellKey).memParams
val io = IO(new Bundle {
@@ -110,11 +110,10 @@ class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
when(dec.io.isSync) {
printf("[Load] start sync\n")
}.elsewhen(dec.io.isInput) {
- printf("[Load] start input\n")
- }
- .elsewhen(dec.io.isWeight) {
- printf("[Load] start weight\n")
- }
+ printf("[Load] start input\n")
+ }.elsewhen(dec.io.isWeight) {
+ printf("[Load] start weight\n")
+ }
}
// done
when(state === sSync) {
```
Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services