[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #6240: Add GraphQL server

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #6240:
URL: https://github.com/apache/dolphinscheduler/pull/6240#discussion_r719023031



##########
File path: dolphinscheduler-dao/src/main/resources/datasource.properties
##########
@@ -16,16 +16,16 @@
 #
 
 # datasource configuration
-spring.datasource.driver-class-name=org.postgresql.Driver
-spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
-spring.datasource.username=root
-spring.datasource.password=root
+#spring.datasource.driver-class-name=org.postgresql.Driver
+#spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
+#spring.datasource.username=root
+#spring.datasource.password=root
 
 # mysql example
-#spring.datasource.driver-class-name=com.mysql.jdbc.Driver
-#spring.datasource.url=jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8
-#spring.datasource.username=ds_user
-#spring.datasource.password=dolphinscheduler
+spring.datasource.driver-class-name=com.mysql.jdbc.Driver
+spring.datasource.url=jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8
+spring.datasource.username=ds_user
+spring.datasource.password=dolphinscheduler

Review comment:
       @CalvinKirs we'd better provide Spring profiles to allow developers to specify different profile when developing, instead of modifying these over and over, although I think this should not be submitted in this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org