[GitHub] [netbeans] vieiro commented on pull request #5505: Contributor has personal preferences on patterns, and introduces bugs.

["vieiro (via GitHub)" <gi...@apache.org>]

vieiro commented on PR #5505:
URL: https://github.com/apache/netbeans/pull/5505#issuecomment-1434911570

   Readability is, [by definition](https://www.oxfordlearnersdictionaries.com/definition/english/readability) a subjective concept. We could be discussing forever on the different aspects that make code legible. NetBeans PRs are not the proper place to discuss readability concerns.
   
   The definition of readability ("the fact of being clear and easy to read") clearly involves the _reader_ of a text, ant not the _writer_ of the text. At least two different readers in this thread have claimed this is less legible to them.
   
   Again (for the third? fourth? time) the recommendation to @tbw777 is to discuss  these things in the mailing list _before_ submitting a PR, at the cost of wasted  contributor _and_ reviewer time.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists