You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/20 15:52:01 UTC
[GitHub] [ignite-3] sanpwc commented on a change in pull request #134: IGNITE-14741
sanpwc commented on a change in pull request #134:
URL: https://github.com/apache/ignite-3/pull/134#discussion_r636233694
##########
File path: modules/affinity/src/main/java/org/apache/ignite/internal/affinity/AffinityManager.java
##########
@@ -88,7 +88,9 @@ public AffinityManager(
metaStorageMgr.registerWatchByPrefix(new ByteArray(INTERNAL_PREFIX), new WatchListener() {
@Override public boolean onUpdate(@NotNull WatchEvent watchEvt) {
for (EntryEvent evt : watchEvt.entryEvents()) {
- String tabIdVal = evt.newEntry().key().toString().substring(INTERNAL_PREFIX.length());
+ String keyAsString = new String(evt.newEntry().key().bytes(), StandardCharsets.UTF_8);
Review comment:
I'd rather use
```
new ByteArray(evt.newEntry().key().bytes()).toString()
```
in order to hide StandardCharsets.UTF_8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org